From issues-return-134928-archive-asf-public=cust-asf.ponee.io@hive.apache.org Wed Sep 5 07:37:04 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 7FD5B180654 for ; Wed, 5 Sep 2018 07:37:03 +0200 (CEST) Received: (qmail 45922 invoked by uid 500); 5 Sep 2018 05:37:02 -0000 Mailing-List: contact issues-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list issues@hive.apache.org Received: (qmail 45913 invoked by uid 99); 5 Sep 2018 05:37:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 05 Sep 2018 05:37:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 3D0E71A097C for ; Wed, 5 Sep 2018 05:37:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id FMCOcbBxlzmc for ; Wed, 5 Sep 2018 05:37:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 409F45F3EE for ; Wed, 5 Sep 2018 05:37:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 76A57E0047 for ; Wed, 5 Sep 2018 05:37:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 1C68023F98 for ; Wed, 5 Sep 2018 05:37:00 +0000 (UTC) Date: Wed, 5 Sep 2018 05:37:00 +0000 (UTC) From: "Ashutosh Chauhan (JIRA)" To: issues@hive.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HIVE-20432) Rewrite BETWEEN to IN for integer types for stats estimation MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HIVE-20432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16603938#comment-16603938 ] Ashutosh Chauhan commented on HIVE-20432: ----------------------------------------- 1. Instead of if (leftValue instanceof Integer) {..} else if (leftValue instanceof Long) {...} else {} you may simply do long leftVal = ((Number) leftValue).longValue() concise and simpler to read. 2. In isIntegerType() you also need to add || primitiveCategory == PrimitiveCategory.BYTE in if () for tinyint. +1 pending these changes. > Rewrite BETWEEN to IN for integer types for stats estimation > ------------------------------------------------------------ > > Key: HIVE-20432 > URL: https://issues.apache.org/jira/browse/HIVE-20432 > Project: Hive > Issue Type: Improvement > Affects Versions: 4.0.0 > Reporter: Vineet Garg > Assignee: Vineet Garg > Priority: Major > Attachments: HIVE-20432.1.patch, HIVE-20432.2.patch, HIVE-20432.3.patch > > > IN clause provides better statistics estimation since predicates are equality based and it keeps into account selectivity of all values. BETWEEN is rewritten into {{>= AND <=}} i.e. non-equality predicates which cause worse estimation. For integer types BETWEEN could be rewritten into IN e.g. BETWEEN 4 and 7 is equivalent to IN (4,5,6,7). -- This message was sent by Atlassian JIRA (v7.6.3#76005)