From issues-return-136108-archive-asf-public=cust-asf.ponee.io@hive.apache.org Fri Sep 14 19:33:06 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 75A3F18076D for ; Fri, 14 Sep 2018 19:33:04 +0200 (CEST) Received: (qmail 94756 invoked by uid 500); 14 Sep 2018 17:33:03 -0000 Mailing-List: contact issues-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list issues@hive.apache.org Received: (qmail 94745 invoked by uid 99); 14 Sep 2018 17:33:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 14 Sep 2018 17:33:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id C6F3D1A1816 for ; Fri, 14 Sep 2018 17:33:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id nJV0qXRfwnr6 for ; Fri, 14 Sep 2018 17:33:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id ACF5B5F5C4 for ; Fri, 14 Sep 2018 17:33:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 29281E25D5 for ; Fri, 14 Sep 2018 17:33:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 99BD323FA6 for ; Fri, 14 Sep 2018 17:33:00 +0000 (UTC) Date: Fri, 14 Sep 2018 17:33:00 +0000 (UTC) From: "Sahil Takiar (JIRA)" To: issues@hive.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HIVE-20273) Spark jobs aren't cancelled if getSparkJobInfo or getSparkStagesInfo MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HIVE-20273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16615124#comment-16615124 ] Sahil Takiar commented on HIVE-20273: ------------------------------------- This patch makes the following fixes: * Fixes the "double-nesting" issue by removing the second clause of the if statement mentioned above * Adds proper and consistent handling of interrupts to {{getWebUIURL}} and {{getAppID}} in {{RemoteSparkJobStatus}} * Adds several unit tests that validate that {{killJob}} is invoked whenever an RPC call is interrupted > Spark jobs aren't cancelled if getSparkJobInfo or getSparkStagesInfo > -------------------------------------------------------------------- > > Key: HIVE-20273 > URL: https://issues.apache.org/jira/browse/HIVE-20273 > Project: Hive > Issue Type: Sub-task > Components: Spark > Reporter: Sahil Takiar > Assignee: Sahil Takiar > Priority: Major > Attachments: HIVE-20273.1.patch > > > HIVE-19053 and HIVE-19733 added handling of {{InterruptedException}} to {{RemoteSparkJobStatus#getSparkJobInfo}} and {{RemoteSparkJobStatus#getSparkStagesInfo}}. Now, these methods catch {{InterruptedException}} and wrap the exception in a {{HiveException}} and then throw the new {{HiveException}}. > This new {{HiveException}} is then caught in {{RemoteSparkJobMonitor#startMonitor}} which then looks for exceptions that match the condition: > {code:java} > if (e instanceof InterruptedException || > (e instanceof HiveException && e.getCause() instanceof InterruptedException)) > {code} > If this condition is met (in this case it is), the exception will again be wrapped in another {{HiveException}} and is thrown again. So the final exception is a {{HiveException}} that wraps a {{HiveException}} that wraps an {{InterruptedException}}. > The double nesting of hive exception causes the logic in {{SparkTask#setSparkException}} to break, and doesn't cause {{killJob}} to get triggered. > This causes interrupted Hive queries to not kill their corresponding Spark jobs. -- This message was sent by Atlassian JIRA (v7.6.3#76005)