hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hive QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-20651) JdbcStorageHandler password should be encrypted
Date Sat, 29 Sep 2018 01:10:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-20651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16632695#comment-16632695
] 

Hive QA commented on HIVE-20651:
--------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  0s{color} |
{color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 48s{color} | {color:blue}
Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  8m  6s{color}
| {color:green} master passed {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red}  3m 37s{color} | {color:red}
root in master failed. {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 15s{color}
| {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m 25s{color} | {color:blue}
jdbc-handler in master has 11 extant Findbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  4m 11s{color} | {color:blue}
ql in master has 2322 extant Findbugs warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  8m 21s{color} |
{color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m  8s{color} | {color:blue}
Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  8m 30s{color}
| {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red}  3m 39s{color} | {color:red}
root in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red}  3m 39s{color} | {color:red}
root in the patch failed. {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  0m 10s{color} | {color:red}
jdbc-handler: The patch generated 4 new + 23 unchanged - 1 fixed = 27 total (was 24) {color}
|
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  0m 44s{color} | {color:red}
ql: The patch generated 3 new + 374 unchanged - 0 fixed = 377 total (was 374) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m  0s{color}
| {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  0m 29s{color} |
{color:green} jdbc-handler generated 0 new + 10 unchanged - 1 fixed = 10 total (was 11) {color}
|
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  4m 22s{color} | {color:red}
ql generated 2 new + 2320 unchanged - 2 fixed = 2322 total (was 2322) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  8m  3s{color} |
{color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red}  0m 13s{color} | {color:red}
The patch generated 1 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 56m 50s{color} | {color:black}
{color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:ql |
|  |  Found reliance on default encoding in org.apache.hadoop.hive.ql.exec.Utilities.copyJobSecretToTableProperties(TableDesc):in
org.apache.hadoop.hive.ql.exec.Utilities.copyJobSecretToTableProperties(TableDesc): new String(byte[])
 At Utilities.java:[line 2315] |
|  |  Found reliance on default encoding in org.apache.hadoop.hive.ql.plan.PlanUtils.configureJobConf(TableDesc,
JobConf):in org.apache.hadoop.hive.ql.plan.PlanUtils.configureJobConf(TableDesc, JobConf):
String.getBytes()  At PlanUtils.java:[line 989] |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  findbugs  checkstyle  compile  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03)
x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-14111/dev-support/hive-personality.sh
|
| git revision | master / 6e27a53 |
| Default Java | 1.8.0_111 |
| compile | http://104.198.109.242/logs//PreCommit-HIVE-Build-14111/yetus/branch-compile-root.txt
|
| findbugs | v3.0.0 |
| compile | http://104.198.109.242/logs//PreCommit-HIVE-Build-14111/yetus/patch-compile-root.txt
|
| javac | http://104.198.109.242/logs//PreCommit-HIVE-Build-14111/yetus/patch-compile-root.txt
|
| checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-14111/yetus/diff-checkstyle-jdbc-handler.txt
|
| checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-14111/yetus/diff-checkstyle-ql.txt
|
| findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-14111/yetus/new-findbugs-ql.html
|
| asflicense | http://104.198.109.242/logs//PreCommit-HIVE-Build-14111/yetus/patch-asflicense-problems.txt
|
| modules | C: . jdbc-handler ql U: . |
| Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-14111/yetus.txt |
| Powered by | Apache Yetus    http://yetus.apache.org |


This message was automatically generated.



> JdbcStorageHandler password should be encrypted
> -----------------------------------------------
>
>                 Key: HIVE-20651
>                 URL: https://issues.apache.org/jira/browse/HIVE-20651
>             Project: Hive
>          Issue Type: Improvement
>          Components: StorageHandler
>            Reporter: Daniel Dai
>            Assignee: Daniel Dai
>            Priority: Major
>         Attachments: HIVE-20651.1.patch
>
>
> Currently, external jdbc table with JdbcStorageHandler store password as "hive.sql.dbcp.password"
table property in clear text. We should put it in a keystore file. Here is the proposed change:
> {code:java}
> ….
> STORED BY 'org.apache.hive.storage.jdbc.JdbcStorageHandler'
> TBLPROPERTIES (
> "hive.sql.dbcp.password.keystore" = "hdfs:///user/hive/credential/postgres.jceks",
> "hive.sql.dbcp.password.key" = "mydb.password"
> );
> {code}
>  
> The jceks file is created with:
> {code}
> hadoop credential create mydb.password -provider hdfs:///user/hive/credential/postgres.jceks
-v secretpassword
> {code}
> User can choose to put all db password in one jceks, or a separate jceks for each db.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message