hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hive QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-18908) FULL OUTER JOIN to MapJoin
Date Sat, 01 Sep 2018 11:52:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-18908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16599620#comment-16599620
] 

Hive QA commented on HIVE-18908:
--------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  0s{color} |
{color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 18s{color} | {color:blue}
Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  8m 19s{color}
| {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  8m 40s{color} |
{color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  3m  0s{color}
| {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m 23s{color} | {color:blue}
storage-api in master has 48 extant Findbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m 35s{color} | {color:blue}
common in master has 64 extant Findbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m 41s{color} | {color:blue}
serde in master has 195 extant Findbugs warnings. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  4m 23s{color} | {color:red}
branch/itests/hive-jmh cannot run convertXmlToText from findbugs {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  4m 15s{color} | {color:blue}
ql in master has 2310 extant Findbugs warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  8m 37s{color} |
{color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m  6s{color} | {color:blue}
Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  9m 42s{color}
| {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  8m 38s{color} |
{color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  8m 38s{color} | {color:green}
the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  0m 12s{color} | {color:red}
itests/hive-jmh: The patch generated 1 new + 11 unchanged - 6 fixed = 12 total (was 17) {color}
|
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  1m 35s{color} | {color:red}
ql: The patch generated 370 new + 3485 unchanged - 187 fixed = 3855 total (was 3672) {color}
|
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red}  0m  1s{color} | {color:red}
The patch has 13 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>.
Refer https://git-scm.com/docs/git-apply {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 13m 34s{color} | {color:red}
patch/itests/hive-jmh cannot run convertXmlToText from findbugs {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  4m 26s{color} | {color:red}
ql generated 16 new + 2309 unchanged - 1 fixed = 2325 total (was 2310) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  8m 51s{color} |
{color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 13s{color}
| {color:green} The patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 92m 28s{color} | {color:black}
{color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:ql |
|  |  Unused field:VectorMapJoinFastLongHashMap.java |
|  |  Unused field:VectorMapJoinFastLongHashMap.java |
|  |  Field VectorMapJoinFastNonMatchedIterator.nonMatchedLogicalSlotNum masks field in superclass
org.apache.hadoop.hive.ql.exec.vector.mapjoin.hashtable.VectorMapJoinNonMatchedIterator  In
VectorMapJoinFastNonMatchedIterator.java:superclass org.apache.hadoop.hive.ql.exec.vector.mapjoin.hashtable.VectorMapJoinNonMatchedIterator
 In VectorMapJoinFastNonMatchedIterator.java |
|  |  Unread public/protected field:At VectorMapJoinNonMatchedIterator.java:[line 38] |
|  |  Dead store to joinDesc in org.apache.hadoop.hive.ql.optimizer.MapJoinProcessor.isFullOuterEnabledForDynamicPartitionHashJoin(HiveConf,
JoinOperator)  At MapJoinProcessor.java:org.apache.hadoop.hive.ql.optimizer.MapJoinProcessor.isFullOuterEnabledForDynamicPartitionHashJoin(HiveConf,
JoinOperator)  At MapJoinProcessor.java:[line 554] |
|  |  Dead store to LA29_5 in org.apache.hadoop.hive.ql.parse.HiveLexer$DFA29.specialStateTransition(int,
IntStream)  At HiveLexer.java:org.apache.hadoop.hive.ql.parse.HiveLexer$DFA29.specialStateTransition(int,
IntStream)  At HiveLexer.java:[line 12751] |
|  |  org.apache.hadoop.hive.ql.plan.VectorMapJoinInfo.getBigTableFilterExpressions() may
expose internal representation by returning VectorMapJoinInfo.bigTableFilterExpressions  At
VectorMapJoinInfo.java:by returning VectorMapJoinInfo.bigTableFilterExpressions  At VectorMapJoinInfo.java:[line
162] |
|  |  org.apache.hadoop.hive.ql.plan.VectorMapJoinInfo.getBigTableRetainColumnMap() may expose
internal representation by returning VectorMapJoinInfo.bigTableRetainColumnMap  At VectorMapJoinInfo.java:by
returning VectorMapJoinInfo.bigTableRetainColumnMap  At VectorMapJoinInfo.java:[line 174]
|
|  |  org.apache.hadoop.hive.ql.plan.VectorMapJoinInfo.getBigTableRetainTypeInfos() may expose
internal representation by returning VectorMapJoinInfo.bigTableRetainTypeInfos  At VectorMapJoinInfo.java:by
returning VectorMapJoinInfo.bigTableRetainTypeInfos  At VectorMapJoinInfo.java:[line 182]
|
|  |  org.apache.hadoop.hive.ql.plan.VectorMapJoinInfo.getNonOuterSmallTableKeyColumnMap()
may expose internal representation by returning VectorMapJoinInfo.nonOuterSmallTableKeyColumnMap
 At VectorMapJoinInfo.java:by returning VectorMapJoinInfo.nonOuterSmallTableKeyColumnMap 
At VectorMapJoinInfo.java:[line 190] |
|  |  org.apache.hadoop.hive.ql.plan.VectorMapJoinInfo.getNonOuterSmallTableKeyTypeInfos()
may expose internal representation by returning VectorMapJoinInfo.nonOuterSmallTableKeyTypeInfos
 At VectorMapJoinInfo.java:by returning VectorMapJoinInfo.nonOuterSmallTableKeyTypeInfos 
At VectorMapJoinInfo.java:[line 198] |
|  |  org.apache.hadoop.hive.ql.plan.VectorMapJoinInfo.setBigTableFilterExpressions(VectorExpression[])
may expose internal representation by storing an externally mutable object into VectorMapJoinInfo.bigTableFilterExpressions
 At VectorMapJoinInfo.java:by storing an externally mutable object into VectorMapJoinInfo.bigTableFilterExpressions
 At VectorMapJoinInfo.java:[line 166] |
|  |  org.apache.hadoop.hive.ql.plan.VectorMapJoinInfo.setBigTableRetainColumnMap(int[]) may
expose internal representation by storing an externally mutable object into VectorMapJoinInfo.bigTableRetainColumnMap
 At VectorMapJoinInfo.java:by storing an externally mutable object into VectorMapJoinInfo.bigTableRetainColumnMap
 At VectorMapJoinInfo.java:[line 170] |
|  |  org.apache.hadoop.hive.ql.plan.VectorMapJoinInfo.setBigTableRetainTypeInfos(TypeInfo[])
may expose internal representation by storing an externally mutable object into VectorMapJoinInfo.bigTableRetainTypeInfos
 At VectorMapJoinInfo.java:by storing an externally mutable object into VectorMapJoinInfo.bigTableRetainTypeInfos
 At VectorMapJoinInfo.java:[line 178] |
|  |  org.apache.hadoop.hive.ql.plan.VectorMapJoinInfo.setNonOuterSmallTableKeyColumnMap(int[])
may expose internal representation by storing an externally mutable object into VectorMapJoinInfo.nonOuterSmallTableKeyColumnMap
 At VectorMapJoinInfo.java:by storing an externally mutable object into VectorMapJoinInfo.nonOuterSmallTableKeyColumnMap
 At VectorMapJoinInfo.java:[line 186] |
|  |  org.apache.hadoop.hive.ql.plan.VectorMapJoinInfo.setNonOuterSmallTableKeyTypeInfos(TypeInfo[])
may expose internal representation by storing an externally mutable object into VectorMapJoinInfo.nonOuterSmallTableKeyTypeInfos
 At VectorMapJoinInfo.java:by storing an externally mutable object into VectorMapJoinInfo.nonOuterSmallTableKeyTypeInfos
 At VectorMapJoinInfo.java:[line 194] |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  findbugs  checkstyle  compile  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03)
x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-13549/dev-support/hive-personality.sh
|
| git revision | master / 57f40f7 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.1 |
| findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-13549/yetus/branch-findbugs-itests_hive-jmh.txt
|
| checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-13549/yetus/diff-checkstyle-itests_hive-jmh.txt
|
| checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-13549/yetus/diff-checkstyle-ql.txt
|
| whitespace | http://104.198.109.242/logs//PreCommit-HIVE-Build-13549/yetus/whitespace-eol.txt
|
| findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-13549/yetus/patch-findbugs-itests_hive-jmh.txt
|
| findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-13549/yetus/new-findbugs-ql.html
|
| modules | C: storage-api common serde . itests itests/hive-jmh ql U: . |
| Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-13549/yetus.txt |
| Powered by | Apache Yetus    http://yetus.apache.org |


This message was automatically generated.



> FULL OUTER JOIN to MapJoin
> --------------------------
>
>                 Key: HIVE-18908
>                 URL: https://issues.apache.org/jira/browse/HIVE-18908
>             Project: Hive
>          Issue Type: Improvement
>          Components: Hive
>            Reporter: Matt McCline
>            Assignee: Matt McCline
>            Priority: Critical
>         Attachments: FULL OUTER MapJoin Code Changes.docx, HIVE-18908.01.patch, HIVE-18908.02.patch,
HIVE-18908.03.patch, HIVE-18908.04.patch, HIVE-18908.05.patch, HIVE-18908.06.patch, HIVE-18908.08.patch,
HIVE-18908.09.patch, HIVE-18908.091.patch, HIVE-18908.092.patch, HIVE-18908.093.patch, HIVE-18908.096.patch,
HIVE-18908.097.patch, HIVE-18908.098.patch, HIVE-18908.099.patch, HIVE-18908.0991.patch, HIVE-18908.0992.patch,
HIVE-18908.0993.patch, JOIN to MAPJOIN Transformation.pdf, SHARED-MEMORY FULL OUTER MapJoin.pdf
>
>
> Currently, we do not support FULL OUTER JOIN in MapJoin.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message