From issues-return-132357-archive-asf-public=cust-asf.ponee.io@hive.apache.org Sun Aug 12 04:33:04 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 00D06180662 for ; Sun, 12 Aug 2018 04:33:03 +0200 (CEST) Received: (qmail 4745 invoked by uid 500); 12 Aug 2018 02:33:02 -0000 Mailing-List: contact issues-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list issues@hive.apache.org Received: (qmail 4736 invoked by uid 99); 12 Aug 2018 02:33:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 12 Aug 2018 02:33:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 085F01A1472 for ; Sun, 12 Aug 2018 02:33:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -108.3 X-Spam-Level: X-Spam-Status: No, score=-108.3 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_BADIPHTTP=2, NORMAL_HTTP_TO_IP=0.001, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id yrDhTFEe1JaD for ; Sun, 12 Aug 2018 02:33:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 1F9345F174 for ; Sun, 12 Aug 2018 02:33:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 7E1E8E070F for ; Sun, 12 Aug 2018 02:33:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 25DC323F9E for ; Sun, 12 Aug 2018 02:33:00 +0000 (UTC) Date: Sun, 12 Aug 2018 02:33:00 +0000 (UTC) From: "Hive QA (JIRA)" To: issues@hive.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HIVE-20368) Remove VectorTopNKeyOperator lock MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HIVE-20368?page=3Dcom.atlassian= .jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1657= 7395#comment-16577395 ]=20 Hive QA commented on HIVE-20368: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12935264/HIVE-20368.2.patc= h {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:green}SUCCESS:{color} +1 due to 14877 tests passed Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/13178/test= Report Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/13178/co= nsole Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-13178/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase {noformat} This message is automatically generated. ATTACHMENT ID: 12935264 - PreCommit-HIVE-Build > Remove VectorTopNKeyOperator lock > --------------------------------- > > Key: HIVE-20368 > URL: https://issues.apache.org/jira/browse/HIVE-20368 > Project: Hive > Issue Type: Bug > Reporter: Teddy Choi > Assignee: Teddy Choi > Priority: Major > Labels: pull-request-available > Attachments: HIVE-20368.1.patch, HIVE-20368.2.patch > > > VectorTopNKeyOperator has a lock in line 199 as following. > {code:java} > priorityQueue.offer(WritableUtils.clone(keysWritable, getConfiguration())= ); > {code} > WritableUtils.clone calls Confgiruation.getClassByNameOrNull that has syn= chronized block. So it needs to=C2=A0run without locks. -- This message was sent by Atlassian JIRA (v7.6.3#76005)