From issues-return-133676-archive-asf-public=cust-asf.ponee.io@hive.apache.org Wed Aug 22 19:29:06 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 35F1E180662 for ; Wed, 22 Aug 2018 19:29:06 +0200 (CEST) Received: (qmail 32224 invoked by uid 500); 22 Aug 2018 17:29:05 -0000 Mailing-List: contact issues-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list issues@hive.apache.org Received: (qmail 32215 invoked by uid 99); 22 Aug 2018 17:29:05 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 22 Aug 2018 17:29:05 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 58A111A27E4 for ; Wed, 22 Aug 2018 17:29:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.301 X-Spam-Level: X-Spam-Status: No, score=-110.301 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id F4SIL02FSp6r for ; Wed, 22 Aug 2018 17:29:03 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 363335F401 for ; Wed, 22 Aug 2018 17:29:03 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 4D141E264F for ; Wed, 22 Aug 2018 17:29:02 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 5015F2475F for ; Wed, 22 Aug 2018 17:29:01 +0000 (UTC) Date: Wed, 22 Aug 2018 17:29:01 +0000 (UTC) From: "Aihua Xu (JIRA)" To: issues@hive.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HIVE-20237) Do Not Print StackTraces to STDERR in HiveMetaStore MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HIVE-20237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aihua Xu updated HIVE-20237: ---------------------------- Resolution: Fixed Fix Version/s: 4.0.0 Status: Resolved (was: Patch Available) Pushed to master. Thanks [~afan] > Do Not Print StackTraces to STDERR in HiveMetaStore > --------------------------------------------------- > > Key: HIVE-20237 > URL: https://issues.apache.org/jira/browse/HIVE-20237 > Project: Hive > Issue Type: Improvement > Components: Standalone Metastore > Affects Versions: 3.0.0, 4.0.0 > Reporter: BELUGA BEHR > Assignee: Alice Fan > Priority: Trivial > Labels: newbie, noob > Fix For: 4.0.0 > > Attachments: HIVE-20237.1.patch, HIVE-20237.2.patch > > > {code:java|title=HiveMetaStore.java} > } catch (Throwable x) { > x.printStackTrace(); > HMSHandler.LOG.error(StringUtils.stringifyException(x)); > throw x; > } > {code} > Bad design here of "log and throw". Don't do it. Just throw the exception and let it be handled, and logged, in one place. At the very least, we don't need the error message to go into the STDERR logs with {{printStackTrace}}, please remove. And remove the {{stringifyException}} code. Just use the normal logging faciltiies at the 'debug' level logging to hide the stack trace during normal operations. > {code} > HMSHandler.LOG.debug("Error", e); > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)