From issues-return-133620-archive-asf-public=cust-asf.ponee.io@hive.apache.org Wed Aug 22 10:18:06 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id BDD3F180662 for ; Wed, 22 Aug 2018 10:18:05 +0200 (CEST) Received: (qmail 73453 invoked by uid 500); 22 Aug 2018 08:18:04 -0000 Mailing-List: contact issues-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list issues@hive.apache.org Received: (qmail 73444 invoked by uid 99); 22 Aug 2018 08:18:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 22 Aug 2018 08:18:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 7400DC5EF5 for ; Wed, 22 Aug 2018 08:18:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -108.3 X-Spam-Level: X-Spam-Status: No, score=-108.3 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_BADIPHTTP=2, NORMAL_HTTP_TO_IP=0.001, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id N_DRnz14Miel for ; Wed, 22 Aug 2018 08:18:03 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 829275F478 for ; Wed, 22 Aug 2018 08:18:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 81C0DE2638 for ; Wed, 22 Aug 2018 08:18:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id B40CF246DB for ; Wed, 22 Aug 2018 08:18:00 +0000 (UTC) Date: Wed, 22 Aug 2018 08:18:00 +0000 (UTC) From: "Hive QA (JIRA)" To: issues@hive.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HIVE-19253) HMS ignores tableType property for external tables MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HIVE-19253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16588532#comment-16588532 ] Hive QA commented on HIVE-19253: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12936533/HIVE-19253.09.patch {color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified. {color:red}ERROR:{color} -1 due to 96 failed/errored test(s), 14886 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestMiniDruidCliDriver.testCliDriver[druidmini_test1] (batchId=194) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query10] (batchId=264) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query11] (batchId=264) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query12] (batchId=264) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query13] (batchId=264) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query14] (batchId=264) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query15] (batchId=264) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query16] (batchId=264) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query17] (batchId=264) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query18] (batchId=264) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query19] (batchId=264) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query1] (batchId=264) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query20] (batchId=264) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query21] (batchId=264) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query22] (batchId=264) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query23] (batchId=264) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query24] (batchId=264) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query25] (batchId=264) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query26] (batchId=264) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query27] (batchId=264) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query29] (batchId=264) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query2] (batchId=264) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query30] (batchId=264) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query31] (batchId=264) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query32] (batchId=264) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query33] (batchId=264) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query34] (batchId=264) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query35] (batchId=264) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query36] (batchId=264) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query37] (batchId=264) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query38] (batchId=264) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query39] (batchId=264) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query3] (batchId=264) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query40] (batchId=264) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query42] (batchId=264) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query43] (batchId=264) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query44] (batchId=264) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query45] (batchId=264) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query46] (batchId=264) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query47] (batchId=264) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query48] (batchId=264) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query49] (batchId=264) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query4] (batchId=264) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query50] (batchId=264) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query51] (batchId=264) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query52] (batchId=264) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query53] (batchId=264) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query54] (batchId=264) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query55] (batchId=264) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query56] (batchId=264) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query57] (batchId=264) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query58] (batchId=264) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query59] (batchId=264) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query5] (batchId=264) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query60] (batchId=264) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query61] (batchId=264) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query63] (batchId=264) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query64] (batchId=264) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query65] (batchId=264) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query66] (batchId=264) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query67] (batchId=264) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query68] (batchId=264) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query69] (batchId=264) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query6] (batchId=264) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query70] (batchId=264) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query71] (batchId=264) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query72] (batchId=264) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query73] (batchId=264) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query74] (batchId=264) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query75] (batchId=264) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query76] (batchId=264) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query77] (batchId=264) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query78] (batchId=264) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query79] (batchId=264) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query7] (batchId=264) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query80] (batchId=264) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query81] (batchId=264) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query82] (batchId=264) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query83] (batchId=264) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query84] (batchId=264) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query85] (batchId=264) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query86] (batchId=264) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query87] (batchId=264) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query88] (batchId=264) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query89] (batchId=264) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query8] (batchId=264) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query90] (batchId=264) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query91] (batchId=264) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query92] (batchId=264) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query93] (batchId=264) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query94] (batchId=264) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query95] (batchId=264) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query96] (batchId=264) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query97] (batchId=264) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query98] (batchId=264) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query99] (batchId=264) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/13391/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/13391/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-13391/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 96 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12936533 - PreCommit-HIVE-Build > HMS ignores tableType property for external tables > -------------------------------------------------- > > Key: HIVE-19253 > URL: https://issues.apache.org/jira/browse/HIVE-19253 > Project: Hive > Issue Type: Bug > Components: Metastore > Affects Versions: 3.0.0, 3.1.0, 4.0.0 > Reporter: Alexander Kolbasov > Assignee: Alexander Kolbasov > Priority: Major > Labels: newbie > Attachments: HIVE-19253.01.patch, HIVE-19253.02.patch, HIVE-19253.03.patch, HIVE-19253.03.patch, HIVE-19253.04.patch, HIVE-19253.05.patch, HIVE-19253.06.patch, HIVE-19253.07.patch, HIVE-19253.08.patch, HIVE-19253.09.patch > > > When someone creates a table using Thrift API they may think that setting tableType to {{EXTERNAL_TABLE}} creates an external table. And boom - their table is gone later because HMS will silently change it to managed table. > here is the offending code: > {code:java} > private MTable convertToMTable(Table tbl) throws InvalidObjectException, > MetaException { > ... > // If the table has property EXTERNAL set, update table type > // accordingly > String tableType = tbl.getTableType(); > boolean isExternal = Boolean.parseBoolean(tbl.getParameters().get("EXTERNAL")); > if (TableType.MANAGED_TABLE.toString().equals(tableType)) { > if (isExternal) { > tableType = TableType.EXTERNAL_TABLE.toString(); > } > } > if (TableType.EXTERNAL_TABLE.toString().equals(tableType)) { > if (!isExternal) { // Here! > tableType = TableType.MANAGED_TABLE.toString(); > } > } > {code} > So if the EXTERNAL parameter is not set, table type is changed to managed even if it was external in the first place - which is wrong. > More over, in other places code looks at the table property to decide table type and some places look at parameter. HMS should really make its mind which one to use. -- This message was sent by Atlassian JIRA (v7.6.3#76005)