hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Teddy Choi (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (HIVE-20315) Vectorization: Fix more NULL / Wrong Results issues and avoid unnecessary casts/conversions
Date Wed, 08 Aug 2018 03:45:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-20315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16572612#comment-16572612
] 

Teddy Choi edited comment on HIVE-20315 at 8/8/18 3:44 AM:
-----------------------------------------------------------

+1 Looks good to me. I ran convert_decimal64_to_decimal.q test with HIVE-20315.08.patch
patch on my machine. It had few differences. Other things look good.


was (Author: teddy.choi):
+1 Looks good to me. I ran convert_decimal64_to_decimal.q test with HIVE-20315.08.patch
patch on my machine. It had just one difference as following. Other things look good.

LINE 184: bigTableKeyExpressions: ConvertDecimal64ToDecimal(col 3:decimal(9,2)/DECIMAL_64)
-> 20:decimal(9,2)

Should be: bigTableKeyExpressions: ConvertDecimal64ToDecimal(col 3:decimal(9,2)/DECIMAL_64)
-> 21:decimal(9,2)

> Vectorization: Fix more NULL / Wrong Results issues and avoid unnecessary casts/conversions
> -------------------------------------------------------------------------------------------
>
>                 Key: HIVE-20315
>                 URL: https://issues.apache.org/jira/browse/HIVE-20315
>             Project: Hive
>          Issue Type: Bug
>          Components: Hive
>            Reporter: Matt McCline
>            Assignee: Matt McCline
>            Priority: Critical
>         Attachments: HIVE-20315.01.patch, HIVE-20315.02.patch, HIVE-20315.03.patch, HIVE-20315.04.patch,
HIVE-20315.05.patch, HIVE-20315.06.patch, HIVE-20315.07.patch, HIVE-20315.08.patch
>
>
> Generate multi-byte Unicode characters in addition to regular single byte characters
for random data.
> Don't CAST from STRING/VARCHAR/CHAR TO STRING since all are stored in vectorization without
padding.
> Fix vectorized BETWEEN expression work to avoid unnecessary CAST of DECIMAL constants.
> Fix NULL / Wrong Results issues in VectorElt.
> Change performance Q files to generate non-user EXPLAIN with VECTORIZATION display so
unnecesary CAST / DECIMAL_64 conversions are visible.
> Add test for vectorized STRUCT field reference.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message