hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hive QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-20255) Review LevelOrderWalker.java
Date Tue, 07 Aug 2018 15:29:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-20255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16571839#comment-16571839
] 

Hive QA commented on HIVE-20255:
--------------------------------



Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12934642/HIVE-20255.2.patch

{color:red}ERROR:{color} -1 due to no test(s) being added or modified.

{color:green}SUCCESS:{color} +1 due to 14867 tests passed

Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/13082/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/13082/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-13082/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12934642 - PreCommit-HIVE-Build

> Review LevelOrderWalker.java
> ----------------------------
>
>                 Key: HIVE-20255
>                 URL: https://issues.apache.org/jira/browse/HIVE-20255
>             Project: Hive
>          Issue Type: Improvement
>          Components: Query Planning
>    Affects Versions: 3.0.0, 4.0.0
>            Reporter: BELUGA BEHR
>            Assignee: BELUGA BEHR
>            Priority: Minor
>         Attachments: HIVE-20255.1.patch, HIVE-20255.2.patch
>
>
> https://github.com/apache/hive/blob/6d890faf22fd1ede3658a5eed097476eab3c67e9/ql/src/java/org/apache/hadoop/hive/ql/lib/LevelOrderWalker.java
> * Make code more concise
> * Fix some check style issues
> {code}
>       if (toWalk.get(index).getChildren() != null) {
>         for(Node child : toWalk.get(index).getChildren()) {
> {code}
> Actually, the underlying implementation of {{getChildren()}} has to do some real work,
so do not throw away the work after checking for null.  Simply call once and store the results.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message