From issues-return-128743-archive-asf-public=cust-asf.ponee.io@hive.apache.org Sat Jul 14 23:58:03 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 3FD0F180632 for ; Sat, 14 Jul 2018 23:58:03 +0200 (CEST) Received: (qmail 64449 invoked by uid 500); 14 Jul 2018 21:58:02 -0000 Mailing-List: contact issues-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list issues@hive.apache.org Received: (qmail 64440 invoked by uid 99); 14 Jul 2018 21:58:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 14 Jul 2018 21:58:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id E8E92CEFEF for ; Sat, 14 Jul 2018 21:58:01 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id vne35ykT4pIm for ; Sat, 14 Jul 2018 21:58:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id D7A6F5F22E for ; Sat, 14 Jul 2018 21:58:00 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 6222DE015A for ; Sat, 14 Jul 2018 21:58:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 1689523F96 for ; Sat, 14 Jul 2018 21:58:00 +0000 (UTC) Date: Sat, 14 Jul 2018 21:58:00 +0000 (UTC) From: "Matt McCline (JIRA)" To: issues@hive.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HIVE-20174) Vectorization: Fix NULL / Wrong Results issues in GROUP BY Aggregation Functions MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HIVE-20174?page=3Dcom.atlassia= n.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt McCline updated HIVE-20174: -------------------------------- Description:=20 Write new UT tests that use random data and intentional isRepeating batches= to checks for NULL and Wrong Results for vectorized=C2=A0aggregation=C2=A0= functions. =C2=A0 BUGs found: 1) AVG/VARIANCE (family) in PARTIAL1 mode was returning NULL instead of cou= nt =3D 0, sum =3D 0 (All data types).=C2=A0 For AVG DECIMAL, only return NU= LL if there was an overflow. 2) AVG/MIN/MAX was not detecting repeated NULL correctly for the TIMESTAMP,= INTERVAL_DAY_TIME, and String Family.=C2=A0 Eliminated redundant code. 3) Fix incorrect calculation=C2=A0 for VARIANCE (family) in PARTIAL2 and FI= NAL modes (HIVE-18758). 4) Fix row-mode AVG DECIMAL to enforce output type precision and scale in C= OMPLETE and FINAL modes. =C2=A0 was: Write new UT tests that use random data and intentional isRepeating batches= to checks for NULL and Wrong Results for vectorized=C2=A0aggregation=C2=A0= functions. =C2=A0 BUGs found: 1) AVG/VARIANCE (family) in PARTIAL1 mode was returning NULL instead of cou= nt =3D 0, sum =3D 0 (All data types).=C2=A0 For AVG DECIMAL, only return NU= LL if there was an overflow. 2) AVG/MIN/MAX was not detecting repeated NULL correctly for the TIMESTAMP,= INTERVAL_DAY_TIME, and String Family.=C2=A0 Eliminated redundant code. 3) Fix incorrect calculation=C2=A0 for VARIANCE (family) in PARTIAL2 and FI= NAL modes. 4) Fix row-mode AVG DECIMAL to enforce output type precision and scale in C= OMPLETE and FINAL modes. =C2=A0 > Vectorization: Fix NULL / Wrong Results issues in GROUP BY Aggregation Fu= nctions > -------------------------------------------------------------------------= ------- > > Key: HIVE-20174 > URL: https://issues.apache.org/jira/browse/HIVE-20174 > Project: Hive > Issue Type: Bug > Components: Hive > Reporter: Matt McCline > Assignee: Matt McCline > Priority: Critical > Attachments: HIVE-20174.01.patch > > > Write new UT tests that use random data and intentional isRepeating batch= es to checks for NULL and Wrong Results for vectorized=C2=A0aggregation=C2= =A0functions. > =C2=A0 > BUGs found: > 1) AVG/VARIANCE (family) in PARTIAL1 mode was returning NULL instead of c= ount =3D 0, sum =3D 0 (All data types).=C2=A0 For AVG DECIMAL, only return = NULL if there was an overflow. > 2) AVG/MIN/MAX was not detecting repeated NULL correctly for the TIMESTAM= P, INTERVAL_DAY_TIME, and String Family.=C2=A0 Eliminated redundant code. > 3) Fix incorrect calculation=C2=A0 for VARIANCE (family) in PARTIAL2 and = FINAL modes (HIVE-18758). > 4) Fix row-mode AVG DECIMAL to enforce output type precision and scale in= COMPLETE and FINAL modes. > =C2=A0 -- This message was sent by Atlassian JIRA (v7.6.3#76005)