From issues-return-128594-archive-asf-public=cust-asf.ponee.io@hive.apache.org Fri Jul 13 16:49:04 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id D72C7180626 for ; Fri, 13 Jul 2018 16:49:03 +0200 (CEST) Received: (qmail 47500 invoked by uid 500); 13 Jul 2018 14:49:02 -0000 Mailing-List: contact issues-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list issues@hive.apache.org Received: (qmail 47491 invoked by uid 99); 13 Jul 2018 14:49:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 13 Jul 2018 14:49:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 48F0B1A3778 for ; Fri, 13 Jul 2018 14:49:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.301 X-Spam-Level: X-Spam-Status: No, score=-110.301 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id OfYfRwTGwmG4 for ; Fri, 13 Jul 2018 14:49:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 445FF5F19D for ; Fri, 13 Jul 2018 14:49:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id CF693E140B for ; Fri, 13 Jul 2018 14:49:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 345F823F9C for ; Fri, 13 Jul 2018 14:49:00 +0000 (UTC) Date: Fri, 13 Jul 2018 14:49:00 +0000 (UTC) From: "BELUGA BEHR (JIRA)" To: issues@hive.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HIVE-20168) ReduceSinkOperator Logging Hidden MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HIVE-20168?page=3Dcom.atlassian= .jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1654= 3294#comment-16543294 ]=20 BELUGA BEHR commented on HIVE-20168: ------------------------------------ Actually... don't remove anything... just change the guards to match the {{= MapOperator}} implementation. Though you should do: {code} if (LOG.isTraceEnabled()) { LOG.info(toString() + ": records written - " + numRows); } // --------------- LOG.info("{} records written - {}", this, numRows); {code} > ReduceSinkOperator Logging Hidden > --------------------------------- > > Key: HIVE-20168 > URL: https://issues.apache.org/jira/browse/HIVE-20168 > Project: Hive > Issue Type: Bug > Components: Operators > Affects Versions: 3.0.0, 4.0.0 > Reporter: BELUGA BEHR > Priority: Minor > Labels: newbie, noob > > [https://github.com/apache/hive/blob/ac6b2a3fb195916e22b2e5f465add2ffbcdc= 7430/ql/src/java/org/apache/hadoop/hive/ql/exec/ReduceSinkOperator.java] > =C2=A0 > {code:java} > if (LOG.isTraceEnabled()) { > if (numRows =3D=3D cntr) { > cntr =3D logEveryNRows =3D=3D 0 ? cntr * 10 : numRows + logEveryNRows= ; > if (cntr < 0 || numRows < 0) { > cntr =3D 0; > numRows =3D 1; > } > LOG.info(toString() + ": records written - " + numRows); > } > } > ... > if (LOG.isTraceEnabled()) { > LOG.info(toString() + ": records written - " + numRows); > } > {code} > There are logging guards here checking for TRACE level debugging but the = logging is actually INFO. This is important logging for detecting data ske= w. Please change guards to check for INFO... or I would prefer that the gu= ards are removed altogether since it's very rare that a service is running = with only WARN level logging. -- This message was sent by Atlassian JIRA (v7.6.3#76005)