From issues-return-130884-archive-asf-public=cust-asf.ponee.io@hive.apache.org Tue Jul 31 01:07:04 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 31080180630 for ; Tue, 31 Jul 2018 01:07:04 +0200 (CEST) Received: (qmail 60274 invoked by uid 500); 30 Jul 2018 23:07:03 -0000 Mailing-List: contact issues-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list issues@hive.apache.org Received: (qmail 60225 invoked by uid 99); 30 Jul 2018 23:07:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 30 Jul 2018 23:07:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id B957B180166 for ; Mon, 30 Jul 2018 23:07:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.301 X-Spam-Level: X-Spam-Status: No, score=-110.301 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id ThhV-dakH0J1 for ; Mon, 30 Jul 2018 23:07:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 9BE8A5F490 for ; Mon, 30 Jul 2018 23:07:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id B9B4CE2629 for ; Mon, 30 Jul 2018 23:07:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 2AE4727762 for ; Mon, 30 Jul 2018 23:07:00 +0000 (UTC) Date: Mon, 30 Jul 2018 23:07:00 +0000 (UTC) From: "Anurag Mantripragada (JIRA)" To: issues@hive.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HIVE-20166) LazyBinaryStruct Warn Level Logging MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HIVE-20166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anurag Mantripragada updated HIVE-20166: ---------------------------------------- Attachment: HIVE-20166.1.patch Status: Patch Available (was: Open) > LazyBinaryStruct Warn Level Logging > ----------------------------------- > > Key: HIVE-20166 > URL: https://issues.apache.org/jira/browse/HIVE-20166 > Project: Hive > Issue Type: Improvement > Components: Serializers/Deserializers > Affects Versions: 3.0.0, 4.0.0 > Reporter: BELUGA BEHR > Assignee: Anurag Mantripragada > Priority: Minor > Labels: newbie, noob > Attachments: HIVE-20166.1.patch > > > https://github.com/apache/hive/blob/6d890faf22fd1ede3658a5eed097476eab3c67e9/serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinaryStruct.java#L177-L180 > {code} > // Extra bytes at the end? > if (!extraFieldWarned && lastFieldByteEnd < structByteEnd) { > extraFieldWarned = true; > LOG.warn("Extra bytes detected at the end of the row! " + > "Last field end " + lastFieldByteEnd + " and serialize buffer end " + structByteEnd + ". " + > "Ignoring similar problems."); > } > // Missing fields? > if (!missingFieldWarned && lastFieldByteEnd > structByteEnd) { > missingFieldWarned = true; > LOG.info("Missing fields! Expected " + fields.length + " fields but " + > "only got " + fieldId + "! " + > "Last field end " + lastFieldByteEnd + " and serialize buffer end " + structByteEnd + ". " + > "Ignoring similar problems."); > } > {code} > The first log statement is a 'warn' level logging, the second is an 'info' level logging. Please change the second log to also be a 'warn'. This seems like it could be a problem that the user would like to know about. -- This message was sent by Atlassian JIRA (v7.6.3#76005)