From issues-return-128681-archive-asf-public=cust-asf.ponee.io@hive.apache.org Sat Jul 14 04:05:05 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id EB99518077A for ; Sat, 14 Jul 2018 04:05:04 +0200 (CEST) Received: (qmail 89404 invoked by uid 500); 14 Jul 2018 02:05:03 -0000 Mailing-List: contact issues-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list issues@hive.apache.org Received: (qmail 89390 invoked by uid 99); 14 Jul 2018 02:05:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 14 Jul 2018 02:05:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 44BBD1807BC for ; Sat, 14 Jul 2018 02:05:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -107.5 X-Spam-Level: X-Spam-Status: No, score=-107.5 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, KAM_BADIPHTTP=2, NORMAL_HTTP_TO_IP=0.001, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id i1Gj4XXVhqas for ; Sat, 14 Jul 2018 02:05:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 8CBDA5F341 for ; Sat, 14 Jul 2018 02:05:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 9E895E2569 for ; Sat, 14 Jul 2018 02:05:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 2A25623F9B for ; Sat, 14 Jul 2018 02:05:00 +0000 (UTC) Date: Sat, 14 Jul 2018 02:05:00 +0000 (UTC) From: "Hive QA (JIRA)" To: issues@hive.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HIVE-20090) Extend creation of semijoin reduction filters to be able to discover new opportunities MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HIVE-20090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16543948#comment-16543948 ] Hive QA commented on HIVE-20090: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12931571/HIVE-20090.08.patch {color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified. {color:green}SUCCESS:{color} +1 due to 14651 tests passed Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/12597/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/12597/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-12597/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase {noformat} This message is automatically generated. ATTACHMENT ID: 12931571 - PreCommit-HIVE-Build > Extend creation of semijoin reduction filters to be able to discover new opportunities > -------------------------------------------------------------------------------------- > > Key: HIVE-20090 > URL: https://issues.apache.org/jira/browse/HIVE-20090 > Project: Hive > Issue Type: Improvement > Components: Physical Optimizer > Reporter: Jesus Camacho Rodriguez > Assignee: Jesus Camacho Rodriguez > Priority: Major > Attachments: HIVE-20090.01.patch, HIVE-20090.02.patch, HIVE-20090.04.patch, HIVE-20090.05.patch, HIVE-20090.06.patch, HIVE-20090.07.patch, HIVE-20090.08.patch > > > Assume the following plan: > {noformat} > TS[0] - RS[1] - JOIN[4] - RS[5] - JOIN[8] - FS[9] > TS[2] - RS[3] - JOIN[4] > TS[6] - RS[7] - JOIN[8] > {noformat} > Currently, {{TS\[6\]}} may only be reduced with the output of {{RS\[5\]}}, i.e., input to join between both subplans. > However, it may be useful to consider other possibilities too, e.g., reduced by the output of {{RS\[1\]}} or {{RS\[3\]}}. For instance, this is important when, given a large plan, an edge between {{RS[5]}} and {{TS[0]}} would create a cycle, while an edge between {{RS[1]}} and {{TS[6]}} would not. > This patch comprises two parts. First, it creates additional predicates when possible. Secondly, it removes duplicate semijoin reduction branches/predicates, e.g., if another semijoin that consumes the output of the same expression already reduces a certain table scan operator (heuristic, since this may not result in most efficient plan in all cases). Ultimately, the decision on whether to use one or another should be cost-driven (follow-up). -- This message was sent by Atlassian JIRA (v7.6.3#76005)