From issues-return-129503-archive-asf-public=cust-asf.ponee.io@hive.apache.org Fri Jul 20 18:36:04 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 1A7FD18067E for ; Fri, 20 Jul 2018 18:36:03 +0200 (CEST) Received: (qmail 43783 invoked by uid 500); 20 Jul 2018 16:36:03 -0000 Mailing-List: contact issues-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list issues@hive.apache.org Received: (qmail 43773 invoked by uid 99); 20 Jul 2018 16:36:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 20 Jul 2018 16:36:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id B11EDC005C for ; Fri, 20 Jul 2018 16:36:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id 7eh-5jgZH5s1 for ; Fri, 20 Jul 2018 16:36:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 736CF5F3CE for ; Fri, 20 Jul 2018 16:36:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id CD8E1E12FE for ; Fri, 20 Jul 2018 16:36:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 5081427144 for ; Fri, 20 Jul 2018 16:36:00 +0000 (UTC) Date: Fri, 20 Jul 2018 16:36:00 +0000 (UTC) From: "Sahil Takiar (JIRA)" To: issues@hive.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HIVE-20032) Don't serialize hashCode when groupByShuffle and RDD cacheing is disabled MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HIVE-20032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16550959#comment-16550959 ] Sahil Takiar commented on HIVE-20032: ------------------------------------- Attached an updated patch that should fix the unit tests. Since the new approach is using reflection to create a class in the {{kryo-registrator}} module, we have to make sure that {{hive-kryo-registrator}} jar file is on the current classpath. Apparently the {{--jar}} option in {{spark-submit}} does not guarantee that for the Spark Driver. So I'm using {{spark.driver.extraClassPath}} to make sure its present when running the {{SparkPlanGenerator}}. When {{spark.master}} is {{local}} things are a bit tricker because there is no separate driver process. So instead I use {{SparkClientUtilities#addJarToContextLoader}} to add the jar to the current classpath. The constructor for {{LocalHiveSparkClient}} is already doing this, but for whatever reason the classloader is getting reset by the time {{SparkPlanGenerator}} runs. I tried debugging it, but didn't have any luck, and given that its just a test infra issue it doesn't seem work resolving unless anyone has suggestions on how to fix it. > Don't serialize hashCode when groupByShuffle and RDD cacheing is disabled > ------------------------------------------------------------------------- > > Key: HIVE-20032 > URL: https://issues.apache.org/jira/browse/HIVE-20032 > Project: Hive > Issue Type: Improvement > Components: Spark > Reporter: Sahil Takiar > Assignee: Sahil Takiar > Priority: Major > Attachments: HIVE-20032.1.patch, HIVE-20032.2.patch, HIVE-20032.3.patch, HIVE-20032.4.patch, HIVE-20032.5.patch, HIVE-20032.6.patch > > > Follow up on HIVE-15104, if we don't enable RDD cacheing or groupByShuffles, then we don't need to serialize the hashCode when shuffling data in HoS. -- This message was sent by Atlassian JIRA (v7.6.3#76005)