hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Prasanth Jayachandran (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-20274) HiveServer2 ObjectInspectorFactory leaks for Struct and List object inspectors
Date Tue, 31 Jul 2018 00:31:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-20274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16562703#comment-16562703
] 

Prasanth Jayachandran commented on HIVE-20274:
----------------------------------------------

yeah. agreed. asMap() is just the underlying reference to CHM used by cache. It will be weak
consistency only with iterables (under certain conditions described in javadoc) other than
that it can be drop in replacement. 

> HiveServer2 ObjectInspectorFactory leaks for Struct and List object inspectors
> ------------------------------------------------------------------------------
>
>                 Key: HIVE-20274
>                 URL: https://issues.apache.org/jira/browse/HIVE-20274
>             Project: Hive
>          Issue Type: Bug
>          Components: HiveServer2
>    Affects Versions: 3.0.0, 4.0.0
>            Reporter: Gopal V
>            Assignee: Prasanth Jayachandran
>            Priority: Major
>         Attachments: HIVE-20274.1.patch
>
>
> Fix in HIVE-19860 needs to be applied to 
> {code}
>   static ConcurrentHashMap<ObjectInspector, StandardListObjectInspector>
>       cachedStandardListObjectInspector = new ConcurrentHashMap<ObjectInspector, StandardListObjectInspector>();
> ...
>   static ConcurrentHashMap<ArrayList<List<?>>, StandardStructObjectInspector>
cachedStandardStructObjectInspector =
>       new ConcurrentHashMap<ArrayList<List<?>>, StandardStructObjectInspector>();
> ...
>   static ConcurrentHashMap<ArrayList<Object>, ColumnarStructObjectInspector>
cachedColumnarStructObjectInspector =
>       new ConcurrentHashMap<ArrayList<Object>, ColumnarStructObjectInspector>();
> {code}
> And possibly for 
> {code}
>   static ConcurrentHashMap<Type, ObjectInspector> objectInspectorCache = new ConcurrentHashMap<Type,
ObjectInspector>();
> ...
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message