hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "BELUGA BEHR (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-20239) Do Not Print StackTraces to STDERR in MapJoinProcessor
Date Fri, 27 Jul 2018 21:08:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-20239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16560328#comment-16560328
] 

BELUGA BEHR commented on HIVE-20239:
------------------------------------

[~anuragmantri]

 
{code:java|title=diff}
       throw new SemanticException("Failed to generate new mapJoin operator " +
-          "by exception : " + e.getMessage());
+          "by exception : " + e);
{code}

Right now, the Exception's {{toString}} is appended to the error message.  It would have to
be:

{code}
       throw new SemanticException("Failed to generate new mapJoin operator", e);
{code}

I just looked at the SemanticException code and that should be acceptable.

> Do Not Print StackTraces to STDERR in MapJoinProcessor
> ------------------------------------------------------
>
>                 Key: HIVE-20239
>                 URL: https://issues.apache.org/jira/browse/HIVE-20239
>             Project: Hive
>          Issue Type: Improvement
>    Affects Versions: 3.0.0
>            Reporter: BELUGA BEHR
>            Assignee: Anurag Mantripragada
>            Priority: Minor
>              Labels: newbie, noob
>             Fix For: 4.0.0
>
>         Attachments: HIVE-20239.1.patch
>
>
> {code:java|title=MapJoinProcessor.java}
>     } catch (Exception e) {
>       e.printStackTrace();
>       throw new SemanticException("Failed to generate new mapJoin operator " +
>           "by exception : " + e.getMessage());
>     }
> {code}
> Please change to... something like...
> {code}
>     } catch (Exception e) {
>       throw new SemanticException("Failed to generate new mapJoin operator", e);
>     }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message