hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hive QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-20166) LazyBinaryStruct Warn Level Logging
Date Tue, 31 Jul 2018 02:09:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-20166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16562993#comment-16562993
] 

Hive QA commented on HIVE-20166:
--------------------------------



Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12933680/HIVE-20166.1.patch

{color:red}ERROR:{color} -1 due to no test(s) being added or modified.

{color:green}SUCCESS:{color} +1 due to 14817 tests passed

Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/12953/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/12953/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-12953/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12933680 - PreCommit-HIVE-Build

> LazyBinaryStruct Warn Level Logging
> -----------------------------------
>
>                 Key: HIVE-20166
>                 URL: https://issues.apache.org/jira/browse/HIVE-20166
>             Project: Hive
>          Issue Type: Improvement
>          Components: Serializers/Deserializers
>    Affects Versions: 3.0.0, 4.0.0
>            Reporter: BELUGA BEHR
>            Assignee: Anurag Mantripragada
>            Priority: Minor
>              Labels: newbie, noob
>         Attachments: HIVE-20166.1.patch
>
>
> https://github.com/apache/hive/blob/6d890faf22fd1ede3658a5eed097476eab3c67e9/serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinaryStruct.java#L177-L180
> {code}
>     // Extra bytes at the end?
>     if (!extraFieldWarned && lastFieldByteEnd < structByteEnd) {
>       extraFieldWarned = true;
>       LOG.warn("Extra bytes detected at the end of the row! " +
>            "Last field end " + lastFieldByteEnd + " and serialize buffer end " + structByteEnd
+ ". " +
>                "Ignoring similar problems.");
>     }
>     // Missing fields?
>     if (!missingFieldWarned && lastFieldByteEnd > structByteEnd) {
>       missingFieldWarned = true;
>       LOG.info("Missing fields! Expected " + fields.length + " fields but " +
>               "only got " + fieldId + "! " +
>           "Last field end " + lastFieldByteEnd + " and serialize buffer end " + structByteEnd
+ ". " +
>           "Ignoring similar problems.");
>     }
> {code}
> The first log statement is a 'warn' level logging, the second is an 'info' level logging.
 Please change the second log to also be a 'warn'.  This seems like it could be a problem
that the user would like to know about.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message