hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hive QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-20158) Do Not Print StackTraces to STDERR in Base64TextOutputFormat
Date Wed, 25 Jul 2018 05:36:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-20158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16555160#comment-16555160
] 

Hive QA commented on HIVE-20158:
--------------------------------



Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12932931/HIVE-20158.2.patch

{color:red}ERROR:{color} -1 due to no test(s) being added or modified.

{color:green}SUCCESS:{color} +1 due to 14687 tests passed

Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/12838/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/12838/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-12838/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12932931 - PreCommit-HIVE-Build

> Do Not Print StackTraces to STDERR in Base64TextOutputFormat
> ------------------------------------------------------------
>
>                 Key: HIVE-20158
>                 URL: https://issues.apache.org/jira/browse/HIVE-20158
>             Project: Hive
>          Issue Type: Improvement
>          Components: Contrib
>    Affects Versions: 3.0.0, 4.0.0
>            Reporter: BELUGA BEHR
>            Assignee: Andrew Sherman
>            Priority: Trivial
>              Labels: newbie, noob
>         Attachments: HIVE-20158.1.patch, HIVE-20158.2.patch
>
>
> https://github.com/apache/hive/blob/6d890faf22fd1ede3658a5eed097476eab3c67e9/contrib/src/java/org/apache/hadoop/hive/contrib/fileformat/base64/Base64TextOutputFormat.java
> {code}
>       try {
>         String signatureString = job.get("base64.text.output.format.signature");
>         if (signatureString != null) {
>           signature = signatureString.getBytes("UTF-8");
>         } else {
>           signature = new byte[0];
>         }
>       } catch (UnsupportedEncodingException e) {
>         e.printStackTrace();
>       }
> {code}
> The {{UnsupportedEncodingException}} is coming from the {{getBytes}} method call.  Instead,
use the {{CharSet}} version of the method and it doesn't throw this explicit exception so
the 'try' block can simply be removed.  Every JVM will support UTF-8.
> https://docs.oracle.com/javase/7/docs/api/java/lang/String.html#getBytes(java.nio.charset.Charset)
> https://docs.oracle.com/javase/7/docs/api/java/nio/charset/StandardCharsets.html#UTF_8



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message