hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hive QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-20046) remove NUM_FILES check
Date Sat, 21 Jul 2018 09:22:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-20046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16551592#comment-16551592
] 

Hive QA commented on HIVE-20046:
--------------------------------



Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12932470/HIVE-20046.01.patch

{color:green}SUCCESS:{color} +1 due to 25 test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 6 failed/errored test(s), 14692 tests executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[stats_part2] (batchId=21)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[acid_no_buckets] (batchId=173)
org.apache.hadoop.hive.metastore.client.TestAlterPartitions.testRenamePartitionNullDbName[Remote]
(batchId=220)
org.apache.hadoop.hive.metastore.client.TestAlterPartitions.testRenamePartitionNullNewPart[Remote]
(batchId=220)
org.apache.hadoop.hive.metastore.client.TestAlterPartitions.testRenamePartitionNullOldPartList[Remote]
(batchId=220)
org.apache.hadoop.hive.metastore.client.TestAlterPartitions.testRenamePartitionNullTblName[Remote]
(batchId=220)
{noformat}

Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/12757/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/12757/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-12757/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 6 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12932470 - PreCommit-HIVE-Build

> remove NUM_FILES check
> ----------------------
>
>                 Key: HIVE-20046
>                 URL: https://issues.apache.org/jira/browse/HIVE-20046
>             Project: Hive
>          Issue Type: Sub-task
>            Reporter: Sergey Shelukhin
>            Assignee: Sergey Shelukhin
>            Priority: Major
>         Attachments: HIVE-20046.01.patch
>
>
> {noformat}
>     // Since newly initialized empty table has 0 for the parameter.
>     if (Long.parseLong(statsParams.get(StatsSetupConst.NUM_FILES)) == 0) {
>       return true;
>     }
> {noformat}
> This doesn't look safe; # of files could be set to 0 by an invalid update, or potentially
a parallel update that we cannot see (not sure if this is possible; there's some code in metastore
that updates basic stats outside of the scope of the query).
> It would be better to remove this, and see if it breaks some tests. If we do need this,
there should be a negative test at some point



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message