hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sergey Shelukhin (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HIVE-20046) [phase 2] remove NUM_FILES check or add a negative test
Date Thu, 19 Jul 2018 23:32:00 GMT

     [ https://issues.apache.org/jira/browse/HIVE-20046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Sergey Shelukhin updated HIVE-20046:
------------------------------------
    Status: Patch Available  (was: Open)

> [phase 2] remove NUM_FILES check or add a negative test
> -------------------------------------------------------
>
>                 Key: HIVE-20046
>                 URL: https://issues.apache.org/jira/browse/HIVE-20046
>             Project: Hive
>          Issue Type: Sub-task
>            Reporter: Sergey Shelukhin
>            Assignee: Sergey Shelukhin
>            Priority: Major
>         Attachments: HIVE-20046.patch
>
>
> {noformat}
>     // Since newly initialized empty table has 0 for the parameter.
>     if (Long.parseLong(statsParams.get(StatsSetupConst.NUM_FILES)) == 0) {
>       return true;
>     }
> {noformat}
> This doesn't look safe; # of files could be set to 0 by an invalid update, or potentially
a parallel update that we cannot see (not sure if this is possible; there's some code in metastore
that updates basic stats outside of the scope of the query).
> It would be better to remove this, and see if it breaks some tests. If we do need this,
there should be a negative test at some point



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message