hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hive QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-19267) Create/Replicate ACID Write event
Date Mon, 02 Jul 2018 16:05:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-19267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16530116#comment-16530116
] 

Hive QA commented on HIVE-19267:
--------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  0s{color} |
{color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  1m 31s{color} | {color:blue}
Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  6m  9s{color}
| {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  2m 55s{color} |
{color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  2m 11s{color}
| {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  3m  1s{color} | {color:blue}
standalone-metastore in master has 228 extant Findbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  3m 55s{color} | {color:blue}
ql in master has 2287 extant Findbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m 25s{color} | {color:blue}
hcatalog/server-extensions in master has 4 extant Findbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m 37s{color} | {color:blue}
itests/hive-unit in master has 2 extant Findbugs warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  2m 34s{color} |
{color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 26s{color} | {color:blue}
Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  3m 33s{color}
| {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  3m  1s{color} |
{color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  3m  1s{color} | {color:green}
the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  0m 41s{color} | {color:red}
standalone-metastore: The patch generated 7 new + 2187 unchanged - 6 fixed = 2194 total (was
2193) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  0m 52s{color} | {color:red}
ql: The patch generated 6 new + 1246 unchanged - 19 fixed = 1252 total (was 1265) {color}
|
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 11s{color}
| {color:green} hcatalog/server-extensions: The patch generated 0 new + 4 unchanged - 3 fixed
= 4 total (was 7) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 11s{color}
| {color:green} The patch hcatalog-unit passed checkstyle {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  0m 23s{color} | {color:red}
itests/hive-unit: The patch generated 38 new + 654 unchanged - 5 fixed = 692 total (was 659)
{color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red}  0m  0s{color} | {color:red}
The patch has 44 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>.
Refer https://git-scm.com/docs/git-apply {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  4m  4s{color} | {color:red}
ql generated 1 new + 2286 unchanged - 1 fixed = 2287 total (was 2287) {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  0m 34s{color} | {color:red}
hcatalog/server-extensions generated 1 new + 2 unchanged - 2 fixed = 3 total (was 4) {color}
|
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  2m 34s{color} |
{color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 12s{color}
| {color:green} The patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 46m 19s{color} | {color:black}
{color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:ql |
|  |  Found reliance on default encoding in org.apache.hadoop.hive.ql.parse.repl.dump.events.CommitTxnHandler.writer(EventHandler$Context,
Path):in org.apache.hadoop.hive.ql.parse.repl.dump.events.CommitTxnHandler.writer(EventHandler$Context,
Path): new java.io.OutputStreamWriter(OutputStream)  At CommitTxnHandler.java:[line 52] |
| FindBugs | module:hcatalog/server-extensions |
|  |  org.apache.hive.hcatalog.listener.DbNotificationListener.addWriteNotificationLog(NotificationEvent,
AcidWriteEvent, Connection, SQLGenerator, AcidWriteMessage) passes a nonconstant String to
an execute or addBatch method on an SQL statement  At DbNotificationListener.java:passes a
nonconstant String to an execute or addBatch method on an SQL statement  At DbNotificationListener.java:[line
779] |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  findbugs  checkstyle  compile  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03)
x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-12328/dev-support/hive-personality.sh
|
| git revision | master / 88da0e8 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-12328/yetus/diff-checkstyle-standalone-metastore.txt
|
| checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-12328/yetus/diff-checkstyle-ql.txt
|
| checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-12328/yetus/diff-checkstyle-itests_hive-unit.txt
|
| whitespace | http://104.198.109.242/logs//PreCommit-HIVE-Build-12328/yetus/whitespace-eol.txt
|
| findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-12328/yetus/new-findbugs-ql.html
|
| findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-12328/yetus/new-findbugs-hcatalog_server-extensions.html
|
| modules | C: standalone-metastore ql hcatalog/server-extensions itests/hcatalog-unit itests/hive-unit
U: . |
| Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-12328/yetus.txt |
| Powered by | Apache Yetus    http://yetus.apache.org |


This message was automatically generated.



> Create/Replicate ACID Write event
> ---------------------------------
>
>                 Key: HIVE-19267
>                 URL: https://issues.apache.org/jira/browse/HIVE-19267
>             Project: Hive
>          Issue Type: Sub-task
>          Components: repl, Transactions
>    Affects Versions: 3.0.0
>            Reporter: mahesh kumar behera
>            Assignee: mahesh kumar behera
>            Priority: Major
>              Labels: ACID, DR, pull-request-available, replication
>         Attachments: HIVE-19267.01-branch-3.patch, HIVE-19267.01.patch, HIVE-19267.02.patch,
HIVE-19267.03.patch, HIVE-19267.04.patch, HIVE-19267.05.patch, HIVE-19267.06.patch, HIVE-19267.07.patch,
HIVE-19267.08.patch, HIVE-19267.09.patch, HIVE-19267.10.patch, HIVE-19267.11.patch, HIVE-19267.12.patch,
HIVE-19267.13.patch, HIVE-19267.14.patch, HIVE-19267.15.patch, HIVE-19267.16.patch, HIVE-19267.17.patch,
HIVE-19267.18.patch, HIVE-19267.19.patch, HIVE-19267.20.patch, HIVE-19267.21.patch, HIVE-19267.22.patch
>
>
>  
> h1. Replicate ACID write Events
>  * Create new EVENT_WRITE event with related message format to log the write operations
with in a txn along with data associated.
>  * Log this event when perform any writes (insert into, insert overwrite, load table,
delete, update, merge, truncate) on table/partition.
>  * If a single MERGE/UPDATE/INSERT/DELETE statement operates on multiple partitions,
then need to log one event per partition.
>  * DbNotificationListener should log this type of event to special metastore table named
"MTxnWriteNotificationLog".
>  * This table should maintain a map of txn ID against list of tables/partitions written
by given txn.
>  * The entry for a given txn should be removed by the cleaner thread that removes the
expired events from EventNotificationTable.
> h1. Replicate Commit Txn operation (with writes)
> Add new EVENT_COMMIT_TXN to log the metadata/data of all tables/partitions modified within
the txn.
> *Source warehouse:*
>  * This event should read the EVENT_WRITEs from "MTxnWriteNotificationLog" metastore
table to consolidate the list of tables/partitions modified within this txn scope.
>  * Based on the list of tables/partitions modified and table Write ID, need to compute
the list of delta files added by this txn.
>  * Repl dump should read this message and dump the metadata and delta files list.
> *Target warehouse:*
>  * Ensure snapshot isolation at target for on-going read txns which shouldn't view the
data replicated from committed txn. (Ensured with open and allocate write ID events).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message