hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hive QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-20007) Hive should carry out timestamp computations in UTC
Date Thu, 28 Jun 2018 08:07:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-20007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16526076#comment-16526076
] 

Hive QA commented on HIVE-20007:
--------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  0s{color} |
{color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  1m  2s{color} | {color:blue}
Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  5m 57s{color}
| {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 10m 48s{color} |
{color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 11m 14s{color}
| {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m 26s{color} | {color:blue}
storage-api in master has 48 extant Findbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m 30s{color} | {color:blue}
common in master has 62 extant Findbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m 40s{color} | {color:blue}
serde in master has 190 extant Findbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  3m  0s{color} | {color:blue}
standalone-metastore in master has 228 extant Findbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m 30s{color} | {color:blue}
llap-common in master has 71 extant Findbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  3m 46s{color} | {color:blue}
ql in master has 2280 extant Findbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m 38s{color} | {color:blue}
llap-server in master has 83 extant Findbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m 28s{color} | {color:blue}
accumulo-handler in master has 21 extant Findbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m 29s{color} | {color:blue}
druid-handler in master has 13 extant Findbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m 28s{color} | {color:blue}
hbase-handler in master has 15 extant Findbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m 37s{color} | {color:blue}
hcatalog/core in master has 33 extant Findbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m 26s{color} | {color:blue}
hcatalog/hcatalog-pig-adapter in master has 2 extant Findbugs warnings. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 12m 18s{color} | {color:red}
branch/itests/hive-jmh cannot run convertXmlToText from findbugs {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m 36s{color} | {color:blue}
itests/hive-unit in master has 2 extant Findbugs warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 14m 21s{color} |
{color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 23s{color} | {color:blue}
Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 12m 21s{color}
| {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 10m 31s{color} |
{color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 10m 31s{color} | {color:green}
the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 11s{color}
| {color:green} The patch storage-api passed checkstyle {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  0m 17s{color} | {color:red}
common: The patch generated 10 new + 466 unchanged - 16 fixed = 476 total (was 482) {color}
|
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  1m 11s{color} | {color:red}
serde: The patch generated 81 new + 3760 unchanged - 93 fixed = 3841 total (was 3853) {color}
|
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 21s{color}
| {color:green} standalone-metastore: The patch generated 0 new + 348 unchanged - 1 fixed
= 348 total (was 349) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 12s{color}
| {color:green} The patch vector-code-gen passed checkstyle {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 10s{color}
| {color:green} llap-common: The patch generated 0 new + 7 unchanged - 2 fixed = 7 total (was
9) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  2m 32s{color} | {color:red}
ql: The patch generated 389 new + 7517 unchanged - 228 fixed = 7906 total (was 7745) {color}
|
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  0m 15s{color} | {color:red}
llap-server: The patch generated 1 new + 153 unchanged - 0 fixed = 154 total (was 153) {color}
|
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 12s{color}
| {color:green} The patch accumulo-handler passed checkstyle {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  0m 12s{color} | {color:red}
druid-handler: The patch generated 1 new + 134 unchanged - 2 fixed = 135 total (was 136) {color}
|
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 11s{color}
| {color:green} hbase-handler: The patch generated 0 new + 18 unchanged - 1 fixed = 18 total
(was 19) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 13s{color}
| {color:green} The patch core passed checkstyle {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  0m 15s{color} | {color:red}
hcatalog/hcatalog-pig-adapter: The patch generated 14 new + 239 unchanged - 17 fixed = 253
total (was 256) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  5m 10s{color} | {color:red}
root: The patch generated 496 new + 13217 unchanged - 360 fixed = 13713 total (was 13577)
{color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 10s{color}
| {color:green} The patch hive-jmh passed checkstyle {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 17s{color}
| {color:green} The patch hive-unit passed checkstyle {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red}  0m  0s{color} | {color:red}
The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>.
Refer https://git-scm.com/docs/git-apply {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  0m 22s{color} | {color:red}
patch/storage-api cannot run setBugDatabaseInfo from findbugs {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  0m 29s{color} | {color:red}
patch/common cannot run setBugDatabaseInfo from findbugs {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  0m 35s{color} | {color:red}
patch/serde cannot run setBugDatabaseInfo from findbugs {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  2m 55s{color} | {color:red}
patch/standalone-metastore cannot run setBugDatabaseInfo from findbugs {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  0m 26s{color} | {color:red}
patch/llap-common cannot run setBugDatabaseInfo from findbugs {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  3m 48s{color} | {color:red}
patch/ql cannot run setBugDatabaseInfo from findbugs {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  0m 36s{color} | {color:red}
patch/llap-server cannot run setBugDatabaseInfo from findbugs {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  0m 28s{color} | {color:red}
patch/accumulo-handler cannot run setBugDatabaseInfo from findbugs {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  0m 24s{color} | {color:red}
patch/druid-handler cannot run setBugDatabaseInfo from findbugs {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  0m 28s{color} | {color:red}
patch/hbase-handler cannot run setBugDatabaseInfo from findbugs {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  0m 32s{color} | {color:red}
patch/hcatalog/core cannot run setBugDatabaseInfo from findbugs {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  0m 25s{color} | {color:red}
patch/hcatalog/hcatalog-pig-adapter cannot run setBugDatabaseInfo from findbugs {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  2m 43s{color} | {color:red}
patch/itests/hive-jmh cannot run setBugDatabaseInfo from findbugs {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  0m 35s{color} | {color:red}
patch/itests/hive-unit cannot run setBugDatabaseInfo from findbugs {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red}  0m 12s{color} | {color:red}
common generated 2 new + 25 unchanged - 0 fixed = 27 total (was 25) {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red}  0m 55s{color} | {color:red}
ql generated 2 new + 98 unchanged - 2 fixed = 100 total (was 100) {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red}  5m 45s{color} | {color:red}
root generated 4 new + 367 unchanged - 2 fixed = 371 total (was 369) {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 11s{color}
| {color:green} The patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black}132m 29s{color} | {color:black}
{color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  findbugs  checkstyle  compile  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03)
x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-12205/dev-support/hive-personality.sh
|
| git revision | master / 67b0a67 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.1 |
| findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-12205/yetus/branch-findbugs-itests_hive-jmh.txt
|
| checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-12205/yetus/diff-checkstyle-common.txt
|
| checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-12205/yetus/diff-checkstyle-serde.txt
|
| checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-12205/yetus/diff-checkstyle-ql.txt
|
| checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-12205/yetus/diff-checkstyle-llap-server.txt
|
| checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-12205/yetus/diff-checkstyle-druid-handler.txt
|
| checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-12205/yetus/diff-checkstyle-hcatalog_hcatalog-pig-adapter.txt
|
| checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-12205/yetus/diff-checkstyle-root.txt
|
| whitespace | http://104.198.109.242/logs//PreCommit-HIVE-Build-12205/yetus/whitespace-eol.txt
|
| findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-12205/yetus/patch-findbugs-storage-api.txt
|
| findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-12205/yetus/patch-findbugs-common.txt
|
| findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-12205/yetus/patch-findbugs-serde.txt
|
| findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-12205/yetus/patch-findbugs-standalone-metastore.txt
|
| findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-12205/yetus/patch-findbugs-llap-common.txt
|
| findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-12205/yetus/patch-findbugs-ql.txt
|
| findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-12205/yetus/patch-findbugs-llap-server.txt
|
| findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-12205/yetus/patch-findbugs-accumulo-handler.txt
|
| findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-12205/yetus/patch-findbugs-druid-handler.txt
|
| findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-12205/yetus/patch-findbugs-hbase-handler.txt
|
| findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-12205/yetus/patch-findbugs-hcatalog_core.txt
|
| findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-12205/yetus/patch-findbugs-hcatalog_hcatalog-pig-adapter.txt
|
| findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-12205/yetus/patch-findbugs-itests_hive-jmh.txt
|
| findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-12205/yetus/patch-findbugs-itests_hive-unit.txt
|
| javadoc | http://104.198.109.242/logs//PreCommit-HIVE-Build-12205/yetus/diff-javadoc-javadoc-common.txt
|
| javadoc | http://104.198.109.242/logs//PreCommit-HIVE-Build-12205/yetus/diff-javadoc-javadoc-ql.txt
|
| javadoc | http://104.198.109.242/logs//PreCommit-HIVE-Build-12205/yetus/diff-javadoc-javadoc-root.txt
|
| modules | C: storage-api common serde standalone-metastore vector-code-gen llap-common ql
llap-server accumulo-handler druid-handler hbase-handler hcatalog/core hcatalog/hcatalog-pig-adapter
. itests itests/hive-jmh itests/hive-unit U: . |
| Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-12205/yetus.txt |
| Powered by | Apache Yetus    http://yetus.apache.org |


This message was automatically generated.



> Hive should carry out timestamp computations in UTC
> ---------------------------------------------------
>
>                 Key: HIVE-20007
>                 URL: https://issues.apache.org/jira/browse/HIVE-20007
>             Project: Hive
>          Issue Type: Sub-task
>          Components: Hive
>            Reporter: Ryan Blue
>            Assignee: Jesus Camacho Rodriguez
>            Priority: Blocker
>              Labels: timestamp
>         Attachments: HIVE-20007.patch
>
>
> Hive currently uses the "local" time of a java.sql.Timestamp to represent the SQL data
type TIMESTAMP WITHOUT TIME ZONE. The purpose is to be able to use {{Timestamp#getYear()}}
and similar methods to implement SQL functions like {{year}}.
> When the SQL session's time zone is a DST zone, such as America/Los_Angeles that alternates
between PST and PDT, there are times that cannot be represented because the effective zone
skips them.
> {code}
> hive> select TIMESTAMP '2015-03-08 02:10:00.101';
> 2015-03-08 03:10:00.101
> {code}
> Using UTC instead of the SQL session time zone as the underlying zone for a java.sql.Timestamp
avoids this bug, while still returning correct values for {{getYear}} etc. Using UTC as the
convenience representation (timestamp without time zone has no real zone) would make timestamp
calculations more consistent and avoid similar problems in the future.
> Notably, this would break the {{unix_timestamp}} UDF that specifies the result is with
respect to ["the default timezone and default locale"|https://cwiki.apache.org/confluence/display/Hive/LanguageManual+UDF#LanguageManualUDF-DateFunctions].
That function would need to be updated to use the {{System.getProperty("user.timezone")}}
zone.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message