hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hive QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-19776) HiveServer2.startHiveServer2 retries of start has concurrency issues
Date Wed, 06 Jun 2018 03:26:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-19776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16502786#comment-16502786
] 

Hive QA commented on HIVE-19776:
--------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  0s{color} |
{color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  6m 43s{color}
| {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 19s{color} |
{color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 11s{color}
| {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m 33s{color} | {color:blue}
service in master has 49 extant Findbugs warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 15s{color} |
{color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 21s{color}
| {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 21s{color} |
{color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 21s{color} | {color:green}
the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  0m 11s{color} | {color:red}
service: The patch generated 4 new + 30 unchanged - 6 fixed = 34 total (was 36) {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red}  0m  0s{color} | {color:red}
The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>.
Refer https://git-scm.com/docs/git-apply {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  0m 40s{color} | {color:red}
service generated 1 new + 47 unchanged - 2 fixed = 48 total (was 49) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 15s{color} |
{color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red}  0m 11s{color} | {color:red}
The patch generated 2 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 10m 21s{color} | {color:black}
{color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:service |
|  |  Exception is caught when Exception is not thrown in org.apache.hive.service.cli.thrift.ThriftBinaryCLIService.initServer()
 At ThriftBinaryCLIService.java:is not thrown in org.apache.hive.service.cli.thrift.ThriftBinaryCLIService.initServer()
 At ThriftBinaryCLIService.java:[line 161] |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  findbugs  checkstyle  compile  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03)
x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-11540/dev-support/hive-personality.sh
|
| git revision | master / 0992d82 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-11540/yetus/diff-checkstyle-service.txt
|
| whitespace | http://104.198.109.242/logs//PreCommit-HIVE-Build-11540/yetus/whitespace-eol.txt
|
| findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-11540/yetus/new-findbugs-service.html
|
| asflicense | http://104.198.109.242/logs//PreCommit-HIVE-Build-11540/yetus/patch-asflicense-problems.txt
|
| modules | C: service U: service |
| Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-11540/yetus.txt |
| Powered by | Apache Yetus    http://yetus.apache.org |


This message was automatically generated.



> HiveServer2.startHiveServer2 retries of start has concurrency issues
> --------------------------------------------------------------------
>
>                 Key: HIVE-19776
>                 URL: https://issues.apache.org/jira/browse/HIVE-19776
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Thejas M Nair
>            Assignee: Thejas M Nair
>            Priority: Major
>              Labels: pull-request-available
>         Attachments: HIVE-19776.1.patch, HIVE-19776.2.patch, HIVE-19776.3.patch
>
>
> HS2 starts the thrift binary/http servers in background, while it proceeds to do other
setup (eg create zookeeper entries). If there is a ZK error and it attempts to stop and start
in the retry loop within HiveServer2.startHiveServer2, the retry fails because the thrift
server doesn't get stopped if it was still getting initialized.
> The thrift server initialization and stopping needs to be synchronized.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message