hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vihang Karajgaonkar (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-19718) Adding partitions in bulk also fetches table for each partition
Date Wed, 13 Jun 2018 16:23:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-19718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16511381#comment-16511381
] 

Vihang Karajgaonkar commented on HIVE-19718:
--------------------------------------------

+1 LGTM

> Adding partitions in bulk also fetches table for each partition
> ---------------------------------------------------------------
>
>                 Key: HIVE-19718
>                 URL: https://issues.apache.org/jira/browse/HIVE-19718
>             Project: Hive
>          Issue Type: Bug
>          Components: Metastore
>    Affects Versions: 3.0.0
>         Environment: Looking at {{convertToMPart}}:
> {code:Java}
>   private MPartition convertToMPart(Partition part, boolean useTableCD)
>       throws InvalidObjectException, MetaException {
>     MTable mt = getMTable(part.getCatName(), part.getDbName(), part.getTableName());
>     ...
> {code}
> So what we have as a result is that we fetch table for every partition where it should
be done just once.
>            Reporter: Alexander Kolbasov
>            Assignee: Peter Vary
>            Priority: Major
>         Attachments: HIVE-19718.2.patch, HIVE-19718.3.patch, HIVE-19718.4.patch, HIVE-19718.5.patch,
HIVE-19718.patch
>
>
> The ObjectStore.addPartitions() method does this:
> {code:java}
> for (Partition part : parts) {
>   if (!part.getTableName().equals(tblName) || !part.getDbName().equals(dbName)) {
>     throw new MetaException("Partition does not belong to target table "
>         + dbName + "." + tblName + ": " + part);
>   }
>   MPartition mpart = convertToMPart(part, true); // <-- Here
>   toPersist.add(mpart);
>   ...{code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message