hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Manoj Narayanan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-18882) Do Not Hide Exception in Hive Metastore Client Connection
Date Tue, 19 Jun 2018 06:56:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-18882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16516720#comment-16516720
] 

Manoj Narayanan commented on HIVE-18882:
----------------------------------------

Removed unnecessary log level check. Please review. 

> Do Not Hide Exception in Hive Metastore Client Connection
> ---------------------------------------------------------
>
>                 Key: HIVE-18882
>                 URL: https://issues.apache.org/jira/browse/HIVE-18882
>             Project: Hive
>          Issue Type: Improvement
>          Components: Standalone Metastore
>    Affects Versions: 3.0.0
>            Reporter: BELUGA BEHR
>            Assignee: Manoj Narayanan
>            Priority: Minor
>              Labels: noob
>         Attachments: HIVE-18882.patch
>
>
> [https://github.com/apache/hive/blob/4047befe48c8f762c58d8854e058385c1df151c6/standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java#L526-L531]
>  
> {code:java}
> if (LOG.isDebugEnabled()) {
>   LOG.warn("Failed to connect to the MetaStore Server...", e);
> } else {
>   // Don't print full exception trace if DEBUG is not on.
>   LOG.warn("Failed to connect to the MetaStore Server...");
> }
> {code}
> I do not understand the logic here.  I always want to see the reason for the failure.
Otherwise, I do not know why it is failing unless I restart the server with debug logging
enabled.  By that point, the error may have cleared.  Please just use the Exception in the
WARN output without adding confusing logging for debugging.  This is never an expected behavior...
that enabling debug would change a _warn_ level log message.
> Also... please remove the ellipsis, they add no value. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message