From issues-return-120693-archive-asf-public=cust-asf.ponee.io@hive.apache.org Sun May 27 17:29:04 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 6FBEE18067C for ; Sun, 27 May 2018 17:29:03 +0200 (CEST) Received: (qmail 21856 invoked by uid 500); 27 May 2018 15:29:02 -0000 Mailing-List: contact issues-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list issues@hive.apache.org Received: (qmail 21847 invoked by uid 99); 27 May 2018 15:29:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 27 May 2018 15:29:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 0D815C0042 for ; Sun, 27 May 2018 15:29:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.511 X-Spam-Level: X-Spam-Status: No, score=-109.511 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id KUu9wnN72JFF for ; Sun, 27 May 2018 15:29:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id E18DB5F341 for ; Sun, 27 May 2018 15:29:00 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 6B756E0370 for ; Sun, 27 May 2018 15:29:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 23A3D21095 for ; Sun, 27 May 2018 15:29:00 +0000 (UTC) Date: Sun, 27 May 2018 15:29:00 +0000 (UTC) From: "Ashutosh Chauhan (JIRA)" To: issues@hive.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HIVE-19695) Year Month Day extraction functions need to add an implicit cast for column that are String types MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HIVE-19695?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashutosh Chauhan updated HIVE-19695: ------------------------------------ Attachment: HIVE-19695.patch > Year Month Day extraction functions need to add an implicit cast for column that are String types > ------------------------------------------------------------------------------------------------- > > Key: HIVE-19695 > URL: https://issues.apache.org/jira/browse/HIVE-19695 > Project: Hive > Issue Type: Bug > Components: Druid integration, Query Planning > Affects Versions: 3.0.0 > Reporter: slim bouguerra > Assignee: slim bouguerra > Priority: Major > Fix For: 3.1.0 > > Attachments: HIVE-19695.patch, HIVE-19695.patch > > > To avoid surprising/wrong results, Hive Query plan shall add an explicit cast over non date/timestamp column type when user try to extract Year/Month/Hour etc.. > This is an example of misleading results. > {code} > create table test_base_table(`timecolumn` timestamp, `date_c` string, `timestamp_c` string, `metric_c` double); > insert into test_base_table values ('2015-03-08 00:00:00', '2015-03-10', '2015-03-08 00:00:00', 5.0); > CREATE TABLE druid_test_table > STORED BY 'org.apache.hadoop.hive.druid.DruidStorageHandler' > TBLPROPERTIES ("druid.segment.granularity" = "DAY") > AS select > cast(`timecolumn` as timestamp with local time zone) as `__time`, `date_c`, `timestamp_c`, `metric_c` FROM test_base_table; > select > year(date_c), month(date_c),day(date_c), hour(date_c), > year(timestamp_c), month(timestamp_c),day(timestamp_c), hour(timestamp_c) > from druid_test_table; > {code} > will return the following wrong results: > {code} > PREHOOK: query: select > year(date_c), month(date_c),day(date_c), hour(date_c), > year(timestamp_c), month(timestamp_c),day(timestamp_c), hour(timestamp_c) > from druid_test_table > PREHOOK: type: QUERY > PREHOOK: Input: default@druid_test_table > #### A masked pattern was here #### > POSTHOOK: query: select > year(date_c), month(date_c),day(date_c), hour(date_c), > year(timestamp_c), month(timestamp_c),day(timestamp_c), hour(timestamp_c) > from druid_test_table > POSTHOOK: type: QUERY > POSTHOOK: Input: default@druid_test_table > #### A masked pattern was here #### > 1969 12 31 16 1969 12 31 16 > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)