From issues-return-118471-archive-asf-public=cust-asf.ponee.io@hive.apache.org Wed May 16 08:16:06 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 50A78180669 for ; Wed, 16 May 2018 08:16:06 +0200 (CEST) Received: (qmail 58775 invoked by uid 500); 16 May 2018 06:16:05 -0000 Mailing-List: contact issues-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list issues@hive.apache.org Received: (qmail 58763 invoked by uid 99); 16 May 2018 06:16:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 16 May 2018 06:16:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 6C497C0346 for ; Wed, 16 May 2018 06:16:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -108.31 X-Spam-Level: X-Spam-Status: No, score=-108.31 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_BADIPHTTP=2, NORMAL_HTTP_TO_IP=0.001, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id M87nm5GGZWYC for ; Wed, 16 May 2018 06:16:03 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 37EB55FB9B for ; Wed, 16 May 2018 06:16:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 05979E0F87 for ; Wed, 16 May 2018 06:16:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 456D0217A8 for ; Wed, 16 May 2018 06:16:00 +0000 (UTC) Date: Wed, 16 May 2018 06:16:00 +0000 (UTC) From: "Hive QA (JIRA)" To: issues@hive.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HIVE-19490) Locking on Insert into for non native and managed tables. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HIVE-19490?page=3Dcom.atlassian= .jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1647= 6899#comment-16476899 ]=20 Hive QA commented on HIVE-19490: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12923587/HIVE-19490.5.patc= h {color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified. {color:red}ERROR:{color} -1 due to 4 failed/errored test(s), 14407 tests ex= ecuted *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[bucketsortoptimize_i= nsert_8] (batchId=3D5) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[orc_struct_type_vect= orization] (batchId=3D71) org.apache.hadoop.hive.cli.TestMiniSparkOnYarnCliDriver.testCliDriver[bucke= tizedhiveinputformat] (batchId=3D183) org.apache.hadoop.hive.ql.plan.mapping.TestReOptimization.testStatCachingMe= taStore (batchId=3D299) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/10980/test= Report Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/10980/co= nsole Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-10980/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 4 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12923587 - PreCommit-HIVE-Build > Locking on Insert into for non native and managed tables. > --------------------------------------------------------- > > Key: HIVE-19490 > URL: https://issues.apache.org/jira/browse/HIVE-19490 > Project: Hive > Issue Type: Improvement > Components: Druid integration > Reporter: slim bouguerra > Assignee: slim bouguerra > Priority: Major > Labels: druid, locking > Attachments: HIVE-19490.2.patch, HIVE-19490.3.patch, HIVE-19490.4= .patch, HIVE-19490.5.patch, HIVE-19490.patch > > > Current state of the art:=C2=A0 > Managed non native table like Druid Tables, will need to get a Lock on In= sert into or insert Over write. The nature of this lock is set to Exclusive= by default for any non native table. > This implies that Inserts into Druid table will Lock any read query as we= ll during the execution of the insert into. IMO this lock (on insert into) = is=C2=A0 not needed since the insert statement is appending data and the st= ate of loading it is managed partially by Hive Storage handler hook and par= t of it by Druid.=C2=A0 > What i am proposing is to relax the lock level to shared for all non nati= ve tables on insert into operations and keep it as Exclusive Write for inse= rt Overwrite for now. > =C2=A0 > Any feedback is welcome. > cc [~ekoifman] / [~ashutoshc] / [~jdere] / [~hagleitn] > Also am not sure what is the best way to unit test this currently am usin= g debugger to check if locks are what i except, please let me know if there= is a better way to do this.=C2=A0 > =C2=A0 -- This message was sent by Atlassian JIRA (v7.6.3#76005)