hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hive QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-17852) remove support for list bucketing "stored as directories" in 3.0
Date Mon, 14 May 2018 04:18:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-17852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16473759#comment-16473759
] 

Hive QA commented on HIVE-17852:
--------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  0s{color} |
{color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 48s{color} | {color:blue}
Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  6m 42s{color}
| {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  7m 28s{color} |
{color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 83m 12s{color}
| {color:green} master passed {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  0m 32s{color} | {color:red}
branch/itests/hive-unit cannot run setBugDatabaseInfo from findbugs {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  0m 21s{color} | {color:red}
branch/metastore cannot run setBugDatabaseInfo from findbugs {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  3m 51s{color} | {color:red}
branch/ql cannot run setBugDatabaseInfo from findbugs {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  3m  6s{color} | {color:red}
branch/standalone-metastore cannot run setBugDatabaseInfo from findbugs {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  7m 38s{color} |
{color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m  7s{color} | {color:blue}
Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  9m  0s{color}
| {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  7m 25s{color} |
{color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  7m 25s{color} | {color:green}
the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 52m 49s{color} | {color:red}
root: The patch generated 1398 new + 245048 unchanged - 1515 fixed = 246446 total (was 246563)
{color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  2m 39s{color} | {color:red}
itests/hive-unit: The patch generated 150 new + 11808 unchanged - 157 fixed = 11958 total
(was 11965) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 24m 56s{color} | {color:red}
ql: The patch generated 773 new + 126044 unchanged - 868 fixed = 126817 total (was 126912)
{color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  4m  7s{color} | {color:red}
standalone-metastore: The patch generated 473 new + 19451 unchanged - 488 fixed = 19924 total
(was 19939) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m  0s{color}
| {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green}  0m  2s{color} | {color:green}
The patch has no ill-formed XML file. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  0m 31s{color} | {color:red}
patch/itests/hive-unit cannot run setBugDatabaseInfo from findbugs {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  0m 21s{color} | {color:red}
patch/metastore cannot run setBugDatabaseInfo from findbugs {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  3m 43s{color} | {color:red}
patch/ql cannot run setBugDatabaseInfo from findbugs {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  3m  3s{color} | {color:red}
patch/standalone-metastore cannot run setBugDatabaseInfo from findbugs {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red}  5m 12s{color} | {color:red}
root generated 2 new + 366 unchanged - 2 fixed = 368 total (was 368) {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red}  0m 51s{color} | {color:red}
ql generated 2 new + 98 unchanged - 2 fixed = 100 total (was 100) {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 16s{color}
| {color:green} The patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black}232m 54s{color} | {color:black}
{color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  findbugs  checkstyle  compile  xml  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03)
x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-10917/dev-support/hive-personality.sh
|
| git revision | master / f327624 |
| Default Java | 1.8.0_111 |
| findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-10917/yetus/branch-findbugs-itests_hive-unit.txt
|
| findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-10917/yetus/branch-findbugs-metastore.txt
|
| findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-10917/yetus/branch-findbugs-ql.txt
|
| findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-10917/yetus/branch-findbugs-standalone-metastore.txt
|
| checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-10917/yetus/diff-checkstyle-root.txt
|
| checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-10917/yetus/diff-checkstyle-itests_hive-unit.txt
|
| checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-10917/yetus/diff-checkstyle-ql.txt
|
| checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-10917/yetus/diff-checkstyle-standalone-metastore.txt
|
| findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-10917/yetus/patch-findbugs-itests_hive-unit.txt
|
| findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-10917/yetus/patch-findbugs-metastore.txt
|
| findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-10917/yetus/patch-findbugs-ql.txt
|
| findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-10917/yetus/patch-findbugs-standalone-metastore.txt
|
| javadoc | http://104.198.109.242/logs//PreCommit-HIVE-Build-10917/yetus/diff-javadoc-javadoc-root.txt
|
| javadoc | http://104.198.109.242/logs//PreCommit-HIVE-Build-10917/yetus/diff-javadoc-javadoc-ql.txt
|
| modules | C: . itests/hive-blobstore itests/hive-unit metastore ql standalone-metastore
U: . |
| Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-10917/yetus.txt |
| Powered by | Apache Yetus    http://yetus.apache.org |


This message was automatically generated.



> remove support for list bucketing "stored as directories" in 3.0
> ----------------------------------------------------------------
>
>                 Key: HIVE-17852
>                 URL: https://issues.apache.org/jira/browse/HIVE-17852
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Sergey Shelukhin
>            Assignee: Laszlo Bodor
>            Priority: Major
>         Attachments: HIVE-17852.01.patch
>
>
> From the email thread:
> 1) LB, when stored as directories, adds a lot of low-level complexity to Hive tables
that has to be accounted for in many places in the code where the files are written or modified
- from FSOP to ACID/replication/export.
> 2) While working on some FSOP code I noticed that some of that logic is broken - e.g.
the duplicate file removal from tasks, a pretty fundamental correctness feature in Hive, may
be broken. LB also doesn’t appear to be compatible with e.g. regular bucketing.
> 3) The feature hasn’t seen development activity in a while; it also doesn’t appear
to be used a lot.
> Keeping with the theme of cleaning up “legacy” code for 3.0, I was proposing we remove
it.
> (2) also suggested that, if needed, it might be easier to implement similar functionality
by adding some flexibility to partitions (which LB directories look like anyway); that would
also keep the logic on a higher level of abstraction (split generation, partition pruning)
as opposed to many low-level places like FSOP, etc.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message