hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hive QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-12192) Hive should carry out timestamp computations in UTC
Date Sun, 27 May 2018 05:04:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-12192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16491920#comment-16491920
] 

Hive QA commented on HIVE-12192:
--------------------------------



Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12925013/HIVE-12192.04.patch

{color:red}ERROR:{color} -1 due to build exiting with an error

Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/11247/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/11247/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-11247/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Tests exited with: NonZeroExitCodeException
Command 'bash /data/hiveptest/working/scratch/source-prep.sh' failed with exit status 1 and
output '+ date '+%Y-%m-%d %T.%3N'
2018-05-27 05:02:34.438
+ [[ -n /usr/lib/jvm/java-8-openjdk-amd64 ]]
+ export JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64
+ JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64
+ export PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games
+ PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games
+ export 'ANT_OPTS=-Xmx1g -XX:MaxPermSize=256m '
+ ANT_OPTS='-Xmx1g -XX:MaxPermSize=256m '
+ export 'MAVEN_OPTS=-Xmx1g '
+ MAVEN_OPTS='-Xmx1g '
+ cd /data/hiveptest/working/
+ tee /data/hiveptest/logs/PreCommit-HIVE-Build-11247/source-prep.txt
+ [[ false == \t\r\u\e ]]
+ mkdir -p maven ivy
+ [[ git = \s\v\n ]]
+ [[ git = \g\i\t ]]
+ [[ -z master ]]
+ [[ -d apache-github-source-source ]]
+ [[ ! -d apache-github-source-source/.git ]]
+ [[ ! -d apache-github-source-source ]]
+ date '+%Y-%m-%d %T.%3N'
2018-05-27 05:02:34.441
+ cd apache-github-source-source
+ git fetch origin
+ git reset --hard HEAD
HEAD is now at 1f92316 HIVE-19465: Upgrade ORC to 1.5.0 (Jesus Camacho Rodriguez, reviewed
by Gopal V)
+ git clean -f -d
+ git checkout master
Already on 'master'
Your branch is up-to-date with 'origin/master'.
+ git reset --hard origin/master
HEAD is now at 1f92316 HIVE-19465: Upgrade ORC to 1.5.0 (Jesus Camacho Rodriguez, reviewed
by Gopal V)
+ git merge --ff-only origin/master
Already up-to-date.
+ date '+%Y-%m-%d %T.%3N'
2018-05-27 05:02:35.342
+ rm -rf ../yetus_PreCommit-HIVE-Build-11247
+ mkdir ../yetus_PreCommit-HIVE-Build-11247
+ git gc
+ cp -R . ../yetus_PreCommit-HIVE-Build-11247
+ mkdir /data/hiveptest/logs/PreCommit-HIVE-Build-11247/yetus
+ patchCommandPath=/data/hiveptest/working/scratch/smart-apply-patch.sh
+ patchFilePath=/data/hiveptest/working/scratch/build.patch
+ [[ -f /data/hiveptest/working/scratch/build.patch ]]
+ chmod +x /data/hiveptest/working/scratch/smart-apply-patch.sh
+ /data/hiveptest/working/scratch/smart-apply-patch.sh /data/hiveptest/working/scratch/build.patch
fatal: git diff header lacks filename information when removing 0 leading pathname components
(line 948)
error: cannot apply binary patch to 'data/files/alltypesorc3xcols' without full index line
Falling back to three-way merge...
error: cannot apply binary patch to 'data/files/alltypesorc3xcols' without full index line
error: data/files/alltypesorc3xcols: patch does not apply
error: cannot apply binary patch to 'data/files/orc_split_elim.orc' without full index line
Falling back to three-way merge...
error: cannot apply binary patch to 'data/files/orc_split_elim.orc' without full index line
error: data/files/orc_split_elim.orc: patch does not apply
error: patch failed: llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/OrcEncodedDataReader.java:74
Falling back to three-way merge...
Applied patch to 'llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/OrcEncodedDataReader.java'
cleanly.
error: patch failed: llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/SerDeEncodedDataReader.java:563
Falling back to three-way merge...
Applied patch to 'llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/SerDeEncodedDataReader.java'
with conflicts.
error: patch failed: llap-server/src/java/org/apache/hadoop/hive/llap/io/metadata/ConsumerFileMetadata.java:20
Falling back to three-way merge...
Applied patch to 'llap-server/src/java/org/apache/hadoop/hive/llap/io/metadata/ConsumerFileMetadata.java'
cleanly.
error: patch failed: llap-server/src/java/org/apache/hadoop/hive/llap/io/metadata/OrcFileMetadata.java:22
Falling back to three-way merge...
Applied patch to 'llap-server/src/java/org/apache/hadoop/hive/llap/io/metadata/OrcFileMetadata.java'
cleanly.
error: patch failed: pom.xml:184
Falling back to three-way merge...
Applied patch to 'pom.xml' cleanly.
error: patch failed: ql/pom.xml:943
Falling back to three-way merge...
Applied patch to 'ql/pom.xml' cleanly.
error: patch failed: ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java:29
Falling back to three-way merge...
Applied patch to 'ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java' cleanly.
error: patch failed: ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/EncodedTreeReaderFactory.java:23
Falling back to three-way merge...
Applied patch to 'ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/EncodedTreeReaderFactory.java'
cleanly.
error: patch failed: ql/src/java/org/apache/hadoop/hive/ql/io/parquet/vector/ParquetDataColumnReader.java:18
Falling back to three-way merge...
Applied patch to 'ql/src/java/org/apache/hadoop/hive/ql/io/parquet/vector/ParquetDataColumnReader.java'
with conflicts.
error: patch failed: ql/src/test/results/clientpositive/orc_file_dump.q.out:102
Falling back to three-way merge...
Applied patch to 'ql/src/test/results/clientpositive/orc_file_dump.q.out' with conflicts.
error: patch failed: ql/src/test/results/clientpositive/orc_merge11.q.out:81
Falling back to three-way merge...
Applied patch to 'ql/src/test/results/clientpositive/orc_merge11.q.out' with conflicts.
error: patch failed: ql/src/test/results/clientpositive/orc_merge12.q.out:161
Falling back to three-way merge...
Applied patch to 'ql/src/test/results/clientpositive/orc_merge12.q.out' with conflicts.
error: patch failed: ql/src/test/results/clientpositive/vector_case_when_2.q.out:129
Falling back to three-way merge...
Applied patch to 'ql/src/test/results/clientpositive/vector_case_when_2.q.out' with conflicts.
error: patch failed: ql/src/test/results/clientpositive/vector_data_types.q.out:127
Falling back to three-way merge...
Applied patch to 'ql/src/test/results/clientpositive/vector_data_types.q.out' with conflicts.
error: patch failed: ql/src/test/results/clientpositive/vector_interval_1.q.out:80
Falling back to three-way merge...
Applied patch to 'ql/src/test/results/clientpositive/vector_interval_1.q.out' with conflicts.
fatal: git diff header lacks filename information when removing 2 leading pathname components
(line 1456)
The patch does not appear to apply with p0, p1, or p2
+ exit 1
'
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12925013 - PreCommit-HIVE-Build

> Hive should carry out timestamp computations in UTC
> ---------------------------------------------------
>
>                 Key: HIVE-12192
>                 URL: https://issues.apache.org/jira/browse/HIVE-12192
>             Project: Hive
>          Issue Type: Sub-task
>          Components: Hive
>            Reporter: Ryan Blue
>            Assignee: Jesus Camacho Rodriguez
>            Priority: Blocker
>              Labels: timestamp
>         Attachments: HIVE-12192.01.patch, HIVE-12192.02.patch, HIVE-12192.03.patch, HIVE-12192.04.patch,
HIVE-12192.patch
>
>
> Hive currently uses the "local" time of a java.sql.Timestamp to represent the SQL data
type TIMESTAMP WITHOUT TIME ZONE. The purpose is to be able to use {{Timestamp#getYear()}}
and similar methods to implement SQL functions like {{year}}.
> When the SQL session's time zone is a DST zone, such as America/Los_Angeles that alternates
between PST and PDT, there are times that cannot be represented because the effective zone
skips them.
> {code}
> hive> select TIMESTAMP '2015-03-08 02:10:00.101';
> 2015-03-08 03:10:00.101
> {code}
> Using UTC instead of the SQL session time zone as the underlying zone for a java.sql.Timestamp
avoids this bug, while still returning correct values for {{getYear}} etc. Using UTC as the
convenience representation (timestamp without time zone has no real zone) would make timestamp
calculations more consistent and avoid similar problems in the future.
> Notably, this would break the {{unix_timestamp}} UDF that specifies the result is with
respect to ["the default timezone and default locale"|https://cwiki.apache.org/confluence/display/Hive/LanguageManual+UDF#LanguageManualUDF-DateFunctions].
That function would need to be updated to use the {{System.getProperty("user.timezone")}}
zone.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message