From issues-return-113806-archive-asf-public=cust-asf.ponee.io@hive.apache.org Thu Apr 19 17:05:04 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 147ED18076D for ; Thu, 19 Apr 2018 17:05:03 +0200 (CEST) Received: (qmail 77883 invoked by uid 500); 19 Apr 2018 15:05:03 -0000 Mailing-List: contact issues-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list issues@hive.apache.org Received: (qmail 77874 invoked by uid 99); 19 Apr 2018 15:05:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 19 Apr 2018 15:05:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id BE1781806D9 for ; Thu, 19 Apr 2018 15:05:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.311 X-Spam-Level: X-Spam-Status: No, score=-110.311 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id I7QxnY1Sgqr4 for ; Thu, 19 Apr 2018 15:05:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 6E7D55F56B for ; Thu, 19 Apr 2018 15:05:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id A26A5E0BBB for ; Thu, 19 Apr 2018 15:05:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 60285241C6 for ; Thu, 19 Apr 2018 15:05:00 +0000 (UTC) Date: Thu, 19 Apr 2018 15:05:00 +0000 (UTC) From: "Sahil Takiar (JIRA)" To: issues@hive.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HIVE-19158) Fix NPE in the HiveMetastore add partition tests MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HIVE-19158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16444187#comment-16444187 ] Sahil Takiar commented on HIVE-19158: ------------------------------------- +1 [~kuczoram] are the test failures related? If they aren't I will go ahead and push this. > Fix NPE in the HiveMetastore add partition tests > ------------------------------------------------ > > Key: HIVE-19158 > URL: https://issues.apache.org/jira/browse/HIVE-19158 > Project: Hive > Issue Type: Bug > Components: Metastore, Test > Reporter: Marta Kuczora > Assignee: Marta Kuczora > Priority: Minor > Attachments: HIVE-19158.1.patch, HIVE-19158.2.patch, HIVE-19158.3.patch > > > The TestAddPartitions and TestAddPartitionsFromPartSpec tests revealed that NPE is thrown in some cases. These NPEs could be prevented with a simple null check and a MetaException with a proper error message should be thrown instead. > Example: NPE is thrown in the following test cases > * TestAddPartitions > ** testAddPartitionNullPartition > ** testAddPartitionNullValue > ** testAddPartitionsNullList > * TestAddPartitionsFromPartSpec > ** testAddPartitionSpecNullSpec > ** testAddPartitionSpecNullPartList > ** testAddPartitionSpecNoDB > ** testAddPartitionSpecNoTable > ** testAddPartitionSpecNoDBAndTableInPartition > ** testAddPartitionSpecNullPart > ** testAddPartitionSpecChangeRootPathToNull > ** testAddPartitionSpecWithSharedSDNullSd > ** testAddPartitionSpecWithSharedSDNoValue > ** testAddPartitionSpecNullValue -- This message was sent by Atlassian JIRA (v7.6.3#76005)