hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sahil Takiar (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-19158) Fix NPE in the HiveMetastore add partition tests
Date Thu, 19 Apr 2018 15:05:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-19158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16444187#comment-16444187
] 

Sahil Takiar commented on HIVE-19158:
-------------------------------------

+1 [~kuczoram] are the test failures related? If they aren't I will go ahead and push this.

> Fix NPE in the HiveMetastore add partition tests
> ------------------------------------------------
>
>                 Key: HIVE-19158
>                 URL: https://issues.apache.org/jira/browse/HIVE-19158
>             Project: Hive
>          Issue Type: Bug
>          Components: Metastore, Test
>            Reporter: Marta Kuczora
>            Assignee: Marta Kuczora
>            Priority: Minor
>         Attachments: HIVE-19158.1.patch, HIVE-19158.2.patch, HIVE-19158.3.patch
>
>
> The TestAddPartitions and TestAddPartitionsFromPartSpec tests revealed that NPE is thrown
in some cases. These NPEs could be prevented with a simple null check and a MetaException
with a proper error message should be thrown instead.
>  Example: NPE is thrown in the following test cases
>  * TestAddPartitions
>  ** testAddPartitionNullPartition
>  ** testAddPartitionNullValue
>  ** testAddPartitionsNullList
>  * TestAddPartitionsFromPartSpec
>  ** testAddPartitionSpecNullSpec
>  ** testAddPartitionSpecNullPartList
>  ** testAddPartitionSpecNoDB
>  ** testAddPartitionSpecNoTable
>  ** testAddPartitionSpecNoDBAndTableInPartition
>  ** testAddPartitionSpecNullPart
>  ** testAddPartitionSpecChangeRootPathToNull
>  ** testAddPartitionSpecWithSharedSDNullSd
>  ** testAddPartitionSpecWithSharedSDNoValue
>  ** testAddPartitionSpecNullValue



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message