From issues-return-110365-archive-asf-public=cust-asf.ponee.io@hive.apache.org Tue Mar 27 01:47:04 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id C7F10180679 for ; Tue, 27 Mar 2018 01:47:03 +0200 (CEST) Received: (qmail 7230 invoked by uid 500); 26 Mar 2018 23:47:02 -0000 Mailing-List: contact issues-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list issues@hive.apache.org Received: (qmail 7216 invoked by uid 99); 26 Mar 2018 23:47:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 26 Mar 2018 23:47:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 5628418009A for ; Mon, 26 Mar 2018 23:47:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.511 X-Spam-Level: X-Spam-Status: No, score=-109.511 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id ZkupfIHCKMXF for ; Mon, 26 Mar 2018 23:47:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 6FF7B5F3E3 for ; Mon, 26 Mar 2018 23:47:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id D5F7DE0E28 for ; Mon, 26 Mar 2018 23:47:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 4B09521504 for ; Mon, 26 Mar 2018 23:47:00 +0000 (UTC) Date: Mon, 26 Mar 2018 23:47:00 +0000 (UTC) From: "Alexander Kolbasov (JIRA)" To: issues@hive.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HIVE-18755) Modifications to the metastore for catalogs MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HIVE-18755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16414784#comment-16414784 ] Alexander Kolbasov commented on HIVE-18755: ------------------------------------------- [~alangates] Thanks for your replies. A few more comments. # Regarding optional vs non-optional. Your reasoning makes sense, but we will have some calls where catalogs must be optional (for compat reasons). As a result, for some calls it is optional and for some it is required which may be confusing - some calls need to check that the value is present or not, some don't and this will complicate things, so making them uniformly optional may be just simpler. If you think that's not an issue it is fine as well. # {quote}On the comments about getCatalogs(), I don't plan to add a request structure as I don't envision there ever being a structure above catalogs (since that's the way SQL defines it). {quote}. Here is an example use case - your proposed use of catalogs to distinguish between Hive catalog and, say, Kafka catalog. On top of that we want to add "cluster" namespace which distinguish what luster accesses the data and all namespaces may deal with hive and kafka catalogs. Even if you think that this isn't a valid use case now, it may become useful soon, so wouldn't it be better to avoid running into the same issues soon afterwards? # {quote}As to getCatalogs returning a list of strings, it matches the name of getDatabases, which returns a list of DB names. {quote} This doesn't make getDatabases very good API either, so is it better to fix newer ones or duplicate old bad ones? # On auto-creation your reasoning makes sense. # For Location - I see what you mean, can you a) document that and b) make location optional since there are likely to be catalogs for which location isn't anyhow useful. > Modifications to the metastore for catalogs > ------------------------------------------- > > Key: HIVE-18755 > URL: https://issues.apache.org/jira/browse/HIVE-18755 > Project: Hive > Issue Type: Sub-task > Components: Metastore > Reporter: Alan Gates > Assignee: Alan Gates > Priority: Major > Labels: pull-request-available > Fix For: 3.0.0 > > Attachments: HIVE-18755.2.patch, HIVE-18755.3.patch, HIVE-18755.nothrift, HIVE-18755.patch > > > Step 1 of adding catalogs is to add support in the metastore. -- This message was sent by Atlassian JIRA (v7.6.3#76005)