From issues-return-107663-archive-asf-public=cust-asf.ponee.io@hive.apache.org Mon Mar 5 16:42:05 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 3FB42180677 for ; Mon, 5 Mar 2018 16:42:05 +0100 (CET) Received: (qmail 93432 invoked by uid 500); 5 Mar 2018 15:42:04 -0000 Mailing-List: contact issues-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list issues@hive.apache.org Received: (qmail 93414 invoked by uid 99); 5 Mar 2018 15:42:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 05 Mar 2018 15:42:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id BA99B1A0674 for ; Mon, 5 Mar 2018 15:42:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -101.511 X-Spam-Level: X-Spam-Status: No, score=-101.511 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id 9j2v4KuuTIxq for ; Mon, 5 Mar 2018 15:42:03 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 6B0655FAC9 for ; Mon, 5 Mar 2018 15:42:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 6973AE0332 for ; Mon, 5 Mar 2018 15:42:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id CD0652126B for ; Mon, 5 Mar 2018 15:42:00 +0000 (UTC) Date: Mon, 5 Mar 2018 15:42:00 +0000 (UTC) From: "Sankar Hariappan (JIRA)" To: issues@hive.apache.org Message-ID: In-Reply-To: References: Subject: =?utf-8?Q?[jira]_[Commented]_(HIVE-18749?= =?utf-8?Q?)_Need_to=C2=A0replace_transactionId?= =?utf-8?Q?_with_writeId_in_RecordIdentifier_and_other_relevant_contexts.?= MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HIVE-18749?page=3Dcom.atlassian= .jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1638= 6226#comment-16386226 ]=20 Sankar Hariappan commented on HIVE-18749: ----------------------------------------- Attached 02.patch with fix for "invalid_cast_from_binary_1" Other test failures are=C2=A0not relevant: *Failed in master:*=C2=A0auto_sortmerge_join_2,=C2=A0llap_smb,=C2=A0tez_smb= _1,=C2=A0union22,=C2=A0update_notnull_constraint,=C2=A0testTriggerMoveConfl= ictKill *Passed Locally:*=C2=A0parquet_ctas,=C2=A0annotate_stats_filter =C2=A0 > Need to=C2=A0replace transactionId with writeId in RecordIdentifier and o= ther relevant contexts. > -------------------------------------------------------------------------= ------------------ > > Key: HIVE-18749 > URL: https://issues.apache.org/jira/browse/HIVE-18749 > Project: Hive > Issue Type: Sub-task > Components: Transactions > Affects Versions: 3.0.0 > Reporter: Sankar Hariappan > Assignee: Sankar Hariappan > Priority: Minor > Labels: ACID, pull-request-available > Fix For: 3.0.0 > > Attachments: HIVE-18749.01.patch, HIVE-18749.02.patch > > > Per table write ID implementation (HIVE-18192) have replaced global trans= action ID with write ID for the primary key for a row marked by RecordIdent= ifier.Field..transactionId. > Need to replace the same with writeId and update all test results file. > Also,=C2=A0need to update other references (methods/variables) which curr= ently uses transactionId instead of writeId. -- This message was sent by Atlassian JIRA (v7.6.3#76005)