From issues-return-109544-archive-asf-public=cust-asf.ponee.io@hive.apache.org Tue Mar 20 20:54:05 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id AB5E418077A for ; Tue, 20 Mar 2018 20:54:04 +0100 (CET) Received: (qmail 37472 invoked by uid 500); 20 Mar 2018 19:54:03 -0000 Mailing-List: contact issues-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list issues@hive.apache.org Received: (qmail 37432 invoked by uid 99); 20 Mar 2018 19:54:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 20 Mar 2018 19:54:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 2FCCDC7012 for ; Tue, 20 Mar 2018 19:54:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.511 X-Spam-Level: X-Spam-Status: No, score=-109.511 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id asm_Or6dxP-j for ; Tue, 20 Mar 2018 19:54:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id C4E995F520 for ; Tue, 20 Mar 2018 19:54:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id D9C06E0D73 for ; Tue, 20 Mar 2018 19:54:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 3DC18214C5 for ; Tue, 20 Mar 2018 19:54:00 +0000 (UTC) Date: Tue, 20 Mar 2018 19:54:00 +0000 (UTC) From: "Sahil Takiar (JIRA)" To: issues@hive.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HIVE-18745) Fix MetaStore creation in tests, so multiple MetaStores can be started on the same machine MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HIVE-18745?page=3Dcom.atlassian= .jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1640= 6922#comment-16406922 ]=20 Sahil Takiar commented on HIVE-18745: ------------------------------------- A few minor comments: * {{MetastoreConf.setVar(conf, ConfVars.WAREHOUSE, warehouseDir + "/" + met= aStorePort);}} use the {{Path}} class to create the dir rather than string = concatenation * {{LOG.error("MetaStore Thrift Server started on port: {} with warehouse d= ir: {}", metaStorePort, warehouseDir);}} don't think the {{warehouseDir}} v= alue is correct because you are using the original one rather than the one = with the port concatenated * Somewhat out of scope of this JIRA, but should {{MetaStoreTestUtils#start= MetaStore}} even be public? Shouldn't we always use {{#startMetaStoreWithRe= try}} otherwise other tests may run into this issue > Fix MetaStore creation in tests, so multiple MetaStores can be started on= the same machine > -------------------------------------------------------------------------= ----------------- > > Key: HIVE-18745 > URL: https://issues.apache.org/jira/browse/HIVE-18745 > Project: Hive > Issue Type: Sub-task > Reporter: Peter Vary > Assignee: Peter Vary > Priority: Major > Attachments: HIVE-18745.1.patch, HIVE-18745.2.patch, HIVE-18745.3= .patch, HIVE-18745.4.patch, HIVE-18745.5.patch > > > [~janulatha] fixed the problem, when multiple MetaStore tests are started= on the same machine, then they tried to reserve the same port. This caused= flakiness in the MetaStore tests run with the ptest framework. See:=C2=A0H= IVE-18147 > I reviewed the=C2=A0HIVE-17980, and tried to make sure, that the fix rema= ins in every codepath. I was unsuccessful=C2=A0in it.=C2=A0:( > This Jira aims to go through the MetaStore tests, and make sure all of th= em is using the=C2=A0 {{startMetaStoreWithRetry}} method so the different t= ests will not cause each other to fail. Also there were clashes not only in= port numbers, but warehouse directories as well, so this Jira should fix t= hat also. -- This message was sent by Atlassian JIRA (v7.6.3#76005)