hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hive QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-18892) Fix NPEs in HiveMetastore.exchange_partitions method
Date Wed, 07 Mar 2018 19:52:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-18892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16390099#comment-16390099
] 

Hive QA commented on HIVE-18892:
--------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m  0s{color} | {color:blue}
Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  0s{color} |
{color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  7m  2s{color}
| {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 37s{color} |
{color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 17s{color}
| {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 46s{color} |
{color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 42s{color}
| {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 33s{color} |
{color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 33s{color} | {color:green}
the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 17s{color}
| {color:green} standalone-metastore: The patch generated 0 new + 351 unchanged - 26 fixed
= 351 total (was 377) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m  0s{color}
| {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 43s{color} |
{color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red}  0m 12s{color} | {color:red}
The patch generated 49 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 11m 23s{color} | {color:black}
{color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  findbugs  checkstyle  compile  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03)
x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-9537/dev-support/hive-personality.sh
|
| git revision | master / 0cfd4fe |
| Default Java | 1.8.0_111 |
| asflicense | http://104.198.109.242/logs//PreCommit-HIVE-Build-9537/yetus/patch-asflicense-problems.txt
|
| modules | C: standalone-metastore U: standalone-metastore |
| Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-9537/yetus.txt |
| Powered by | Apache Yetus    http://yetus.apache.org |


This message was automatically generated.



> Fix NPEs in HiveMetastore.exchange_partitions method
> ----------------------------------------------------
>
>                 Key: HIVE-18892
>                 URL: https://issues.apache.org/jira/browse/HIVE-18892
>             Project: Hive
>          Issue Type: Bug
>          Components: Metastore
>            Reporter: Marta Kuczora
>            Assignee: Marta Kuczora
>            Priority: Minor
>         Attachments: HIVE-18892.1.patch
>
>
> The TestExchangePartitions tests revealed that NPE is thrown if the exchange_partitions
method is called with null, empty or non-existing DB and table names. These NPEs could be
prevented with a simple null check and a MetaException with a proper error message should
be thrown instead.
> Example: NPE is thrown in the following test cases
>  * testExchangePartitionsNonExistingSourceTable
>  * testExchangePartitionsNonExistingSourceDB
>  * testExchangePartitionsNonExistingDestTable
>  * testExchangePartitionsNonExistingDestDB
>  * testExchangePartitionsEmptySourceTable
>  * testExchangePartitionsEmptySourceDB
>  * testExchangePartitionsEmptyDestTable
>  * testExchangePartitionsEmptyDestDB
>  * testExchangePartitionsNullSourceTable
>  * testExchangePartitionsNullSourceDB
>  * testExchangePartitionsNullDestTable
>  * testExchangePartitionsNullDestDB
>  * testExchangePartitionsNullPartSpec



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message