hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexander Kolbasov (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-18755) Modifications to the metastore for catalogs
Date Mon, 26 Mar 2018 23:47:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-18755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16414784#comment-16414784
] 

Alexander Kolbasov commented on HIVE-18755:
-------------------------------------------

[~alangates] Thanks for your replies. A few more comments.

# Regarding optional vs non-optional. Your reasoning makes sense, but we will have some calls
where catalogs must be optional (for compat reasons). As a result, for some calls it is optional
and for some it is required which may be confusing - some calls need to check that the value
is present or not, some don't and this will complicate things, so making them uniformly optional
may be just simpler. If you think that's not an issue it is fine as well.
# {quote}On the comments about getCatalogs(), I don't plan to add a request structure as I
don't envision there ever being a structure above catalogs (since that's the way SQL defines
it).  {quote}. Here is an example use case - your proposed use of catalogs to distinguish
between Hive catalog and, say, Kafka catalog. On top of that we want to add "cluster" namespace
which distinguish what luster accesses the data and all namespaces may deal with hive and
kafka catalogs. Even if you think that this isn't a valid use case now, it may become useful
soon, so wouldn't it be better to avoid running into the same issues soon afterwards?
# {quote}As to getCatalogs returning a list of strings, it matches the name of getDatabases,
which returns a list of DB names. {quote} This doesn't make getDatabases very good API either,
so is it better to fix newer ones or duplicate old bad ones?
# On auto-creation your reasoning makes sense.
# For Location - I see what you mean, can you a) document that and b) make location optional
since there are likely to be catalogs for which location isn't anyhow useful.


> Modifications to the metastore for catalogs
> -------------------------------------------
>
>                 Key: HIVE-18755
>                 URL: https://issues.apache.org/jira/browse/HIVE-18755
>             Project: Hive
>          Issue Type: Sub-task
>          Components: Metastore
>            Reporter: Alan Gates
>            Assignee: Alan Gates
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 3.0.0
>
>         Attachments: HIVE-18755.2.patch, HIVE-18755.3.patch, HIVE-18755.nothrift, HIVE-18755.patch
>
>
> Step 1 of adding catalogs is to add support in the metastore.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message