hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sahil Takiar (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-18745) Fix MetaStore creation in tests, so multiple MetaStores can be started on the same machine
Date Tue, 20 Mar 2018 19:54:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-18745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16406922#comment-16406922
] 

Sahil Takiar commented on HIVE-18745:
-------------------------------------

A few minor comments:
* {{MetastoreConf.setVar(conf, ConfVars.WAREHOUSE, warehouseDir + "/" + metaStorePort);}}
use the {{Path}} class to create the dir rather than string concatenation
* {{LOG.error("MetaStore Thrift Server started on port: {} with warehouse dir: {}", metaStorePort,
warehouseDir);}} don't think the {{warehouseDir}} value is correct because you are using the
original one rather than the one with the port concatenated
* Somewhat out of scope of this JIRA, but should {{MetaStoreTestUtils#startMetaStore}} even
be public? Shouldn't we always use {{#startMetaStoreWithRetry}} otherwise other tests may
run into this issue

> Fix MetaStore creation in tests, so multiple MetaStores can be started on the same machine
> ------------------------------------------------------------------------------------------
>
>                 Key: HIVE-18745
>                 URL: https://issues.apache.org/jira/browse/HIVE-18745
>             Project: Hive
>          Issue Type: Sub-task
>            Reporter: Peter Vary
>            Assignee: Peter Vary
>            Priority: Major
>         Attachments: HIVE-18745.1.patch, HIVE-18745.2.patch, HIVE-18745.3.patch, HIVE-18745.4.patch,
HIVE-18745.5.patch
>
>
> [~janulatha] fixed the problem, when multiple MetaStore tests are started on the same
machine, then they tried to reserve the same port. This caused flakiness in the MetaStore
tests run with the ptest framework. See: HIVE-18147
> I reviewed the HIVE-17980, and tried to make sure, that the fix remains in every codepath.
I was unsuccessful in it. :(
> This Jira aims to go through the MetaStore tests, and make sure all of them is using
the  {{startMetaStoreWithRetry}} method so the different tests will not cause each other
to fail. Also there were clashes not only in port numbers, but warehouse directories as well,
so this Jira should fix that also.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message