From issues-return-106597-archive-asf-public=cust-asf.ponee.io@hive.apache.org Sat Feb 24 23:21:06 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id EDF8A180656 for ; Sat, 24 Feb 2018 23:21:05 +0100 (CET) Received: (qmail 8900 invoked by uid 500); 24 Feb 2018 22:21:05 -0000 Mailing-List: contact issues-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list issues@hive.apache.org Received: (qmail 8887 invoked by uid 99); 24 Feb 2018 22:21:05 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 24 Feb 2018 22:21:05 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id A7875C0145 for ; Sat, 24 Feb 2018 22:21:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.511 X-Spam-Level: X-Spam-Status: No, score=-109.511 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id 7j07JbbJ8WaO for ; Sat, 24 Feb 2018 22:21:03 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 43C1C5F54E for ; Sat, 24 Feb 2018 22:21:03 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 730C2E03E8 for ; Sat, 24 Feb 2018 22:21:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 375E321902 for ; Sat, 24 Feb 2018 22:21:00 +0000 (UTC) Date: Sat, 24 Feb 2018 22:21:00 +0000 (UTC) From: "Kryvenko Igor (JIRA)" To: issues@hive.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HIVE-18723) CompactorOutputCommitter.commitJob() - check rename() ret val MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HIVE-18723?page=3Dcom.atlassian= .jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1637= 5801#comment-16375801 ]=20 Kryvenko Igor commented on HIVE-18723: -------------------------------------- [~ekoifman], please,can you review?=C2=A0 As i see failed tests are not related to fix. > CompactorOutputCommitter.commitJob() - check rename() ret val > ------------------------------------------------------------- > > Key: HIVE-18723 > URL: https://issues.apache.org/jira/browse/HIVE-18723 > Project: Hive > Issue Type: Improvement > Components: Transactions > Affects Versions: 1.0.0 > Reporter: Eugene Koifman > Assignee: Kryvenko Igor > Priority: Major > Attachments: HIVE-18723.1.patch, HIVE-18723.2.patch, HIVE-18723.p= atch > > > right now ret val is ignored {{fs.rename(fileStatus.getPath(), newPath); = }} > Should this use {{FileUtils.ename(FileSystem fs, Path sourcePath, Path de= stPath, Configuration conf) }} -- This message was sent by Atlassian JIRA (v7.6.3#76005)