From issues-return-104997-archive-asf-public=cust-asf.ponee.io@hive.apache.org Sun Feb 11 11:36:04 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id AC77B180676 for ; Sun, 11 Feb 2018 11:36:04 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 9C546160C36; Sun, 11 Feb 2018 10:36:04 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id E2BCE160C4E for ; Sun, 11 Feb 2018 11:36:03 +0100 (CET) Received: (qmail 97086 invoked by uid 500); 11 Feb 2018 10:36:03 -0000 Mailing-List: contact issues-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list issues@hive.apache.org Received: (qmail 97077 invoked by uid 99); 11 Feb 2018 10:36:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 11 Feb 2018 10:36:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id B39921A04C0 for ; Sun, 11 Feb 2018 10:36:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -101.511 X-Spam-Level: X-Spam-Status: No, score=-101.511 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id gtxuK-bHkr4A for ; Sun, 11 Feb 2018 10:36:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 434665FB29 for ; Sun, 11 Feb 2018 10:36:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 7C1B4E0254 for ; Sun, 11 Feb 2018 10:36:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 24CF421E84 for ; Sun, 11 Feb 2018 10:36:00 +0000 (UTC) Date: Sun, 11 Feb 2018 10:36:00 +0000 (UTC) From: "Matt McCline (JIRA)" To: issues@hive.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HIVE-18622) Vectorization: IF Statements, Comparisons, and more do not handle NULLs correctly MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HIVE-18622?page=3Dcom.atlassia= n.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt McCline updated HIVE-18622: -------------------------------- Attachment: (was: HIVE-18622.08.patch) > Vectorization: IF Statements, Comparisons, and more do not handle NULLs c= orrectly > -------------------------------------------------------------------------= -------- > > Key: HIVE-18622 > URL: https://issues.apache.org/jira/browse/HIVE-18622 > Project: Hive > Issue Type: Bug > Components: Hive > Reporter: Matt McCline > Assignee: Matt McCline > Priority: Critical > Fix For: 3.0.0 > > Attachments: HIVE-18622.03.patch, HIVE-18622.04.patch, HIVE-18622= .05.patch, HIVE-18622.06.patch, HIVE-18622.07.patch > > > =C2=A0 > Many vector expression classes are setting noNulls to true which does no= t work if the VRB is a scratch column being reused. The previous use may ha= ve set noNulls to false and the isNull array will have some rows marked as = NULL. The result is wrong query results and sometimes NPEs (for BytesColumn= Vector). > So, many vector expressions need this: > {code:java} > // Carefully handle NULLs... > /* > * For better performance on LONG/DOUBLE we don't want the conditio= nal > * statements inside the for loop. > */ > outputColVector.noNulls =3D false; > =C2=A0{code} > And, vector expressions need to make sure the isNull array entry is set w= hen outputColVector.noNulls is false. > And, all place that assign column value need to set noNulls to false when= the value is NULL. > Almost all cases where noNulls is set to true are incorrect. -- This message was sent by Atlassian JIRA (v7.6.3#76005)