hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gopal V (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-18660) PCR doesn't distinguish between partition and virtual columns
Date Mon, 12 Feb 2018 19:38:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-18660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16361334#comment-16361334
] 

Gopal V commented on HIVE-18660:
--------------------------------

[~ashutoshc]: the loop is better done as 

{code}
VirtualColumn.VIRTUAL_COLUMN_NAMES.contains(column.getAlias().toUpperCase())
{code}

(or added as a helper function like VirtualColumn::isVirtualColumnBasedOnAlias).

LGTM, with that comment - +1

> PCR doesn't distinguish between partition and virtual columns
> -------------------------------------------------------------
>
>                 Key: HIVE-18660
>                 URL: https://issues.apache.org/jira/browse/HIVE-18660
>             Project: Hive
>          Issue Type: Bug
>          Components: Logical Optimizer
>            Reporter: Ashutosh Chauhan
>            Assignee: Ashutosh Chauhan
>            Priority: Major
>         Attachments: HIVE-18660.patch
>
>
> As a result transforms a filter {{INPUT__FILE__NAME is not null;}} to \{{false}} causing
wrong results.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message