From issues-return-102967-archive-asf-public=cust-asf.ponee.io@hive.apache.org Fri Jan 26 20:02:08 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 0FA0F180676 for ; Fri, 26 Jan 2018 20:02:08 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id F1B7A160C2E; Fri, 26 Jan 2018 19:02:07 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 44A62160C3E for ; Fri, 26 Jan 2018 20:02:07 +0100 (CET) Received: (qmail 37806 invoked by uid 500); 26 Jan 2018 19:02:06 -0000 Mailing-List: contact issues-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list issues@hive.apache.org Received: (qmail 37797 invoked by uid 99); 26 Jan 2018 19:02:06 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 26 Jan 2018 19:02:06 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 13762C2490 for ; Fri, 26 Jan 2018 19:02:06 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -108.31 X-Spam-Level: X-Spam-Status: No, score=-108.31 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_BADIPHTTP=2, NORMAL_HTTP_TO_IP=0.001, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id IzDclyUmMrH3 for ; Fri, 26 Jan 2018 19:02:05 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 5A15B5FB5E for ; Fri, 26 Jan 2018 19:02:04 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id A1697E0662 for ; Fri, 26 Jan 2018 19:02:02 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 35B36240EE for ; Fri, 26 Jan 2018 19:02:01 +0000 (UTC) Date: Fri, 26 Jan 2018 19:02:01 +0000 (UTC) From: "Hive QA (JIRA)" To: issues@hive.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HIVE-18540) remove logic for wide terminal to display in-place updates MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HIVE-18540?page=3Dcom.atlassian= .jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1634= 1438#comment-16341438 ]=20 Hive QA commented on HIVE-18540: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12907683/HIVE-18540.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:red}ERROR:{color} -1 due to 20 failed/errored test(s), 11809 tests e= xecuted *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[mapjoin_hook] (batch= Id=3D12) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[ppd_join5] (batchId= =3D35) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[row__id] (batchId=3D= 78) org.apache.hadoop.hive.cli.TestEncryptedHDFSCliDriver.testCliDriver[encrypt= ion_move_tbl] (batchId=3D173) org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[llap_smb] (b= atchId=3D151) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[bucket_= map_join_tez1] (batchId=3D170) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[insert_= values_orig_table_use_metadata] (batchId=3D165) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[llap_ac= id] (batchId=3D169) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[llap_ac= id_fast] (batchId=3D160) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[resourc= eplan] (batchId=3D163) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[sysdb] = (batchId=3D160) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[tez_smb= _1] (batchId=3D167) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vectori= zation_input_format_excludes] (batchId=3D162) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[ppd_join5] (bat= chId=3D121) org.apache.hadoop.hive.ql.io.TestDruidRecordWriter.testWrite (batchId=3D254= ) org.apache.hive.beeline.cli.TestHiveCli.testNoErrorDB (batchId=3D186) org.apache.hive.hcatalog.listener.TestDbNotificationListener.dropDatabase (= batchId=3D240) org.apache.hive.jdbc.TestSSL.testConnectionMismatch (batchId=3D232) org.apache.hive.jdbc.TestSSL.testConnectionWrongCertCN (batchId=3D232) org.apache.hive.jdbc.TestSSL.testMetastoreConnectionWrongCertCN (batchId=3D= 232) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/8853/testR= eport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/8853/con= sole Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-8853/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 20 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12907683 - PreCommit-HIVE-Build > remove logic for wide terminal to display in-place updates > ----------------------------------------------------------- > > Key: HIVE-18540 > URL: https://issues.apache.org/jira/browse/HIVE-18540 > Project: Hive > Issue Type: Improvement > Affects Versions: 2.3.2 > Reporter: Song Jun > Assignee: Song Jun > Priority: Minor > Attachments: HIVE-18540.patch > > > Hive Shell/beeline run=C2=A0Tez job, when the terminal wide is lower than= 95, there will be no output(progress bar) to the console, because of the f= ollowing limit logic in class InPlaceUpdate: > {code:java} > public static boolean canRenderInPlace(HiveConf conf) { boolean inPlaceUp= dates =3D HiveConf.getBoolVar(conf, HiveConf.ConfVars.TEZ_EXEC_INPLACE_PROG= RESS); // we need at least 80 chars wide terminal to display in-place updat= es properly return inPlaceUpdates && isUnixTerminal() && TerminalFactory.ge= t().getWidth() >=3D MIN_TERMINAL_WIDTH; }{code} > =C2=A0 > {code:java} > && isUnixTerminal() && TerminalFactory.get().getWidth() >=3D MIN_TERMINAL= _WIDTH;{code} > If someone do not know this logic ,and the terminal is not enough wide, h= e will think something wrong and do know how to fix it. > =C2=A0 > and I think it is better to remove the trouble logic. > =C2=A0 -- This message was sent by Atlassian JIRA (v7.6.3#76005)