hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Song Jun (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HIVE-18540) remove logic for wide terminal to display in-place updates
Date Thu, 25 Jan 2018 13:06:00 GMT

     [ https://issues.apache.org/jira/browse/HIVE-18540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Song Jun updated HIVE-18540:
----------------------------
    Attachment: HIVE-18540.patch

>  remove logic for wide terminal to display in-place updates
> -----------------------------------------------------------
>
>                 Key: HIVE-18540
>                 URL: https://issues.apache.org/jira/browse/HIVE-18540
>             Project: Hive
>          Issue Type: Improvement
>    Affects Versions: 2.3.2
>            Reporter: Song Jun
>            Assignee: Song Jun
>            Priority: Minor
>         Attachments: HIVE-18540.patch
>
>
> Hive Shell/beeline run Tez job, when the terminal wide is lower than 95, there will
be no output(progress bar) to the console, because of the following limit logic in class InPlaceUpdate:
> {code:java}
> public static boolean canRenderInPlace(HiveConf conf) { boolean inPlaceUpdates = HiveConf.getBoolVar(conf,
HiveConf.ConfVars.TEZ_EXEC_INPLACE_PROGRESS); // we need at least 80 chars wide terminal to
display in-place updates properly return inPlaceUpdates && isUnixTerminal() &&
TerminalFactory.get().getWidth() >= MIN_TERMINAL_WIDTH; }{code}
>  
> If someone do not know this logic ,and the terminal is not enough wide, he will think
something wrong and do know how to fix it.
>  
> and I think it is better to remove the trouble logic.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message