hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zoltan Haindrich (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HIVE-18238) Driver execution may not have configuration changing sideeffects
Date Wed, 03 Jan 2018 16:22:00 GMT

     [ https://issues.apache.org/jira/browse/HIVE-18238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Zoltan Haindrich updated HIVE-18238:
------------------------------------
    Attachment: HIVE-18238.03.patch

#3)

* {{hive.doing.acid}} is also problematic; I suspect that after 1 acid operation this flag
is left turned on...
* transactional tests are working by changing the config in flight...so for those test cases
the isolation is disabled
* removed the {{Driver.resetQueryState()}} method...I don't think it was ok to call that method
even without isolation...
* removed a driver caching mechanism from {{CommandFactory}}; it seemed to me that it probably
didn't worked lately ; but the conf isolation have bringed it back to life, and caused some
issues - however since hs2 didn't use the cleaner it provided, I've removed it.

> Driver execution may not have configuration changing sideeffects 
> -----------------------------------------------------------------
>
>                 Key: HIVE-18238
>                 URL: https://issues.apache.org/jira/browse/HIVE-18238
>             Project: Hive
>          Issue Type: Sub-task
>          Components: Logical Optimizer
>            Reporter: Zoltan Haindrich
>            Assignee: Zoltan Haindrich
>         Attachments: HIVE-18238.01wip01.patch, HIVE-18238.02.patch, HIVE-18238.03.patch
>
>
> {{Driver}} executes sql statements which use "hiveconf" settings;
> but the {{Driver}} itself may *not* change the configuration...
> I've found an example; which shows how hazardous this is...
> {code}
> set hive.mapred.mode=strict;
> select "${hiveconf:hive.mapred.mode}";
> create table t (a int);
> analyze table t compute statistics;
> select "${hiveconf:hive.mapred.mode}";
> {code}
> currently; the last select returns {{nonstrict}} because of [this|https://github.com/apache/hive/blob/7ddd915bf82a68c8ab73b0c4ca409f1a6d43d227/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java#L1696]



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message