hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zoltan Haindrich (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (HIVE-18012) fix ct_noperm_loc test
Date Thu, 09 Nov 2017 15:06:02 GMT

    [ https://issues.apache.org/jira/browse/HIVE-18012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16245777#comment-16245777
] 

Zoltan Haindrich edited comment on HIVE-18012 at 11/9/17 3:05 PM:
------------------------------------------------------------------

[~ajisakaa] I thinked read/write when I've written ownership - sorry; so the user doesn't
have write privileges - the original buglet people do ctas with arbitrary locations; this
test is added to ensure that create table doesn't get broken later.

I've left out the current SemanticException's message:
{code}
FAILED: SemanticException [Error 10043]: Either list of columns or a custom serializer should
be specified
{code}

I don't entirely agree with the removal of the test; because it seems to me that the previously
working sql statements became unsupported somehow; maybe the test needs updating?

I've made a small change to the test; there was an interesting statement {{create table foo1
location 'hdfs:///tmp/ct_noperm_loc/foo1'}} which have missed the column definitions....

the test now errors out with the following exception: {{FAILED: HiveAccessControlException
Permission denied: Principal [name=user1, type=USER] does not have following privileges for
operation CREATETABLE [[INSERT, DELETE] on Object [type=DFS_URI, name=hdfs://localhost:34855/tmp/ct_noperm_loc/foo1]]}}
which is good

patch to keep test: https://hastebin.com/natotejahu.diff


was (Author: kgyrtkirk):
[~ajisakaa] I thinked read/write when I've written ownership - sorry; so the user doesn't
have write privileges - the original buglet people do ctas with arbitrary locations; this
test is added to ensure that create table doesn't get broken later.

I've left out the current SemanticException's message:
{code}
FAILED: SemanticException [Error 10043]: Either list of columns or a custom serializer should
be specified
{code}

I don't entirely agree with the removal of the test; because it seems to me that the previously
working sql statements became unsupported somehow; maybe the test needs updating?

I've made a small change to the test; there was an interesting statement {{create table foo1
location 'hdfs:///tmp/ct_noperm_loc/foo1'}} which have missed the column definitions....

the test now errors out with the following exception: {{FAILED: HiveAccessControlException
Permission denied: Principal [name=user1, type=USER] does not have following privileges for
operation CREATETABLE [[INSERT, DELETE] on Object [type=DFS_URI, name=hdfs://localhost:34855/tmp/ct_noperm_loc/foo1]]}}
which is good



> fix ct_noperm_loc test
> ----------------------
>
>                 Key: HIVE-18012
>                 URL: https://issues.apache.org/jira/browse/HIVE-18012
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Zoltan Haindrich
>            Assignee: Akira Ajisaka
>         Attachments: HIVE-18012.001.patch
>
>
> the goal of the test is to check that hive doesn't let user1 to create a table with a
location under an unowned path.
> I've bisected this test to be broken by 5250ef450430fcdeed0a2cb7a770f48647987cd3 (HIVE-12408).
> the original exception was (which have been by that sole masked line):
> {code}
> FAILED: HiveAccessControlException Permission denied: Principal [name=user1, type=USER]
does not have following privileges for operation CREATETABLE [[OBJECT OWNERSHIP] on Object
[type=DFS_URI, name=hdfs://localhost:35753/tmp/ct_noperm_loc_foo0]]
> {code}
> the current semanticexception shouldnt be accepted ; because it's unrelated to the tests
goal.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message