hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexander Kolbasov (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-17942) HiveAlterHandler not using conf from HMS Handler
Date Thu, 09 Nov 2017 16:47:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-17942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16246000#comment-16246000
] 

Alexander Kolbasov commented on HIVE-17942:
-------------------------------------------

[~janulatha] Thanks for the explanation. Can you provide some example showing how HMSHandler
configuration may be customized by a user?

Looking at the fix and at your comment - the most important part is that HMSHandler's configuration
may be different from general server configuration and that's the one we should use during
alterTable. The fact that it is thread-local is interesting, but this is really an implementation
detail of HMSHandler.

It would be good to explain this in the story in the code comments.

Another question that I asked - since now the server configuration isn't used by HiveALterHandle,
should it still be Configurable?  What is the value of setConf()/getConf() calls in the new
code?

> HiveAlterHandler not using conf from HMS Handler
> ------------------------------------------------
>
>                 Key: HIVE-17942
>                 URL: https://issues.apache.org/jira/browse/HIVE-17942
>             Project: Hive
>          Issue Type: Bug
>    Affects Versions: 2.1.1
>            Reporter: Janaki Lahorani
>            Assignee: Janaki Lahorani
>             Fix For: 3.0.0
>
>         Attachments: HIVE-17942.1.patch, HIVE-17942.2.patch, HIVE-17942.3.patch, HIVE-17942.4.patch
>
>
> When HiveAlterHandler looks for conf, it is not getting the one from thread local.  So,
local changes are not visible.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message