hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "BELUGA BEHR (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-17901) org.apache.hadoop.hive.ql.exec.Utilities - Use Logging Parameterization and More
Date Thu, 02 Nov 2017 00:51:02 GMT

    [ https://issues.apache.org/jira/browse/HIVE-17901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16235026#comment-16235026
] 

BELUGA BEHR commented on HIVE-17901:
------------------------------------

Adding some more changes...

* Using a global Random object instead of creating it as a local variable for each method
call.  As of JDK 7, Random is thread-safe.
* When creating a random positive number, there is one edge-case where it can still [produce
a negative number|https://stackoverflow.com/questions/5827023/java-random-giving-negative-numbers].
 This patch addresses that.
* Unify how we check for empty collections and empty strings using the handy Apache Commons
library
* Remove dead code

> org.apache.hadoop.hive.ql.exec.Utilities - Use Logging Parameterization and More
> --------------------------------------------------------------------------------
>
>                 Key: HIVE-17901
>                 URL: https://issues.apache.org/jira/browse/HIVE-17901
>             Project: Hive
>          Issue Type: Improvement
>          Components: Hive
>    Affects Versions: 3.0.0
>            Reporter: BELUGA BEHR
>            Assignee: BELUGA BEHR
>            Priority: Minor
>         Attachments: HIVE-17901.1.patch, HIVE-17901.2.patch
>
>
> {{org.apache.hadoop.hive.ql.exec.Utilities}}
> # Remove unused imports
> # Remove unused variables
> # Modify logging to use logging parameterization
> # Other small tweeks



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message