Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 0293D200D36 for ; Mon, 23 Oct 2017 06:36:05 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 00F9B160BD7; Mon, 23 Oct 2017 04:36:05 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 46CAE160BEF for ; Mon, 23 Oct 2017 06:36:04 +0200 (CEST) Received: (qmail 23754 invoked by uid 500); 23 Oct 2017 04:36:03 -0000 Mailing-List: contact issues-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list issues@hive.apache.org Received: (qmail 23745 invoked by uid 99); 23 Oct 2017 04:36:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 23 Oct 2017 04:36:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id C1898C49E7 for ; Mon, 23 Oct 2017 04:36:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 83Y6II5VbVn5 for ; Mon, 23 Oct 2017 04:36:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id B5EB96112D for ; Mon, 23 Oct 2017 04:36:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 27C2CE0F17 for ; Mon, 23 Oct 2017 04:36:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 861572438E for ; Mon, 23 Oct 2017 04:36:00 +0000 (UTC) Date: Mon, 23 Oct 2017 04:36:00 +0000 (UTC) From: "Vihang Karajgaonkar (JIRA)" To: issues@hive.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HIVE-17874) Parquet vectorization fails on tables with complex columns when there are no projected columns MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 23 Oct 2017 04:36:05 -0000 [ https://issues.apache.org/jira/browse/HIVE-17874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16214620#comment-16214620 ] Vihang Karajgaonkar commented on HIVE-17874: -------------------------------------------- Thanks for the review [~Ferd]. I made changes as you suggested. I moved {{colsToInclude = ColumnProjectionUtils.getReadColumnIDs(conf);}} in the {{initialize}} method because I got rid of unnecessary field {{indexColumnsWanted}} and reused colsToInclude instead. I have moved the {{rbCtx = Utilities.getVectorizedRowBatchCtx(conf);}} in the initialize method as well like you suggested. Also updated the comment and removed unnecessary diff. Feel free to let me know if you want me to publish the patch on RB as well. > Parquet vectorization fails on tables with complex columns when there are no projected columns > ---------------------------------------------------------------------------------------------- > > Key: HIVE-17874 > URL: https://issues.apache.org/jira/browse/HIVE-17874 > Project: Hive > Issue Type: Sub-task > Affects Versions: 2.2.0 > Reporter: Vihang Karajgaonkar > Assignee: Vihang Karajgaonkar > Attachments: HIVE-17874.01-branch-2.patch, HIVE-17874.01.patch, HIVE-17874.02.patch > > > When a parquet table contains an unsupported type like {{Map}}, {{LIST}} or {{UNION}} simple queries like {{select count(*) from table}} fails with {{unsupported type exception}} even though vectorized reader doesn't really need read the complex type into batches. -- This message was sent by Atlassian JIRA (v6.4.14#64029)