Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 363F3200D21 for ; Mon, 16 Oct 2017 23:33:05 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 34F31160BE9; Mon, 16 Oct 2017 21:33:05 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 79ADB1609E3 for ; Mon, 16 Oct 2017 23:33:04 +0200 (CEST) Received: (qmail 52508 invoked by uid 500); 16 Oct 2017 21:33:03 -0000 Mailing-List: contact issues-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list issues@hive.apache.org Received: (qmail 52499 invoked by uid 99); 16 Oct 2017 21:33:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 16 Oct 2017 21:33:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id C8739C34D1 for ; Mon, 16 Oct 2017 21:33:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id Q5mN_d21-H8p for ; Mon, 16 Oct 2017 21:33:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 7665B5FCD0 for ; Mon, 16 Oct 2017 21:33:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id C7A6AE0B20 for ; Mon, 16 Oct 2017 21:33:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 7ECC32438A for ; Mon, 16 Oct 2017 21:33:00 +0000 (UTC) Date: Mon, 16 Oct 2017 21:33:00 +0000 (UTC) From: "Mithun Radhakrishnan (JIRA)" To: issues@hive.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HIVE-17802) Remove unnecessary calls to FileSystem.setOwner() from FileOutputCommitterContainer MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 16 Oct 2017 21:33:05 -0000 [ https://issues.apache.org/jira/browse/HIVE-17802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mithun Radhakrishnan updated HIVE-17802: ---------------------------------------- Attachment: HIVE-17802.1.patch Cumulative patch with HIVE-17802, HIVE-17803, and part of HIVE-13989. > Remove unnecessary calls to FileSystem.setOwner() from FileOutputCommitterContainer > ----------------------------------------------------------------------------------- > > Key: HIVE-17802 > URL: https://issues.apache.org/jira/browse/HIVE-17802 > Project: Hive > Issue Type: Bug > Components: HCatalog > Affects Versions: 2.2.0, 3.0.0 > Reporter: Mithun Radhakrishnan > Assignee: Chris Drome > Attachments: HIVE-17802.1.patch > > > For large Pig/HCat queries that produce a large number of partitions/directories/files, we have seen cases where the HDFS NameNode groaned under the weight of {{FileSystem.setOwner()}} calls, originating from the commit-step. This was the result of the following code in FileOutputCommitterContainer: > {code:java} > private void applyGroupAndPerms(FileSystem fs, Path dir, FsPermission permission, > List acls, String group, boolean recursive) > throws IOException { > ... > if (recursive) { > for (FileStatus fileStatus : fs.listStatus(dir)) { > if (fileStatus.isDir()) { > applyGroupAndPerms(fs, fileStatus.getPath(), permission, acls, group, true); > } else { > fs.setPermission(fileStatus.getPath(), permission); > chown(fs, fileStatus.getPath(), group); > } > } > } > } > private void chown(FileSystem fs, Path file, String group) throws IOException { > try { > fs.setOwner(file, null, group); > } catch (AccessControlException ignore) { > // Some users have wrong table group, ignore it. > LOG.warn("Failed to change group of partition directories/files: " + file, ignore); > } > } > {code} > One call per file/directory is far too many. We have a patch that reduces the namenode pressure. -- This message was sent by Atlassian JIRA (v6.4.14#64029)