hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zoltan Haindrich (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (HIVE-17759) Prevent the misuses of HiveConf.ConfVars.default fields
Date Tue, 10 Oct 2017 13:02:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-17759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16198615#comment-16198615
] 

Zoltan Haindrich edited comment on HIVE-17759 at 10/10/17 1:01 PM:
-------------------------------------------------------------------

I would like to recommend to evaluate the following options:

* rethink the whole HiveConf...to use some annotation level thing like:
{code}
@HiveConfVariable{ name="hive.main.asd",
description = "long story",
altNames = {"hadoop.sql.main.sql","hadoop.hive.sql" }
}
Integer asd = 5; // this is the default value
// the type is the field type...can go wrong..
{code}
altought these fields are not entirely used just to collect the informations; I think it would
feel natural...
this might alsp open up the possibility to add some validators to the conf values...because
currently we can't easily specify that something can't be negative...
* introduce some templating if possible....(should HiveConf be tied to an enum?
* or....add some getters which check the current "type" of the conf variable



was (Author: kgyrtkirk):
I would like to recommend to evaluate the following options:

* rethink the whole HiveConf...to use some annotation level thing like:
{code}
@HiveConfVariable{ name="hive.main.asd",
description = "long story",
altNames = {"hadoop.sql.main.sql","hadoop.hive.sql" }
}
Integer asd = 5; // this is the default value
// the type is the field type...can go wrong..
{code}
altought these fields are not entirely used just to collect the informations; I think it would
feel natural...
this also might open up the possibility to add some validators to the conf values...because
currently we can't easily specify that something can't be negative...
* introduce some templating if possible....(should HiveConf be tied to an enum?
* or....add some getters which check the current "type" of the conf variable


> Prevent the misuses of HiveConf.ConfVars.default fields
> -------------------------------------------------------
>
>                 Key: HIVE-17759
>                 URL: https://issues.apache.org/jira/browse/HIVE-17759
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Zoltan Haindrich
>
> issues like HIVE-17758 can be prevented if these fields wouldn't be directly accessible



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message