hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sahil Takiar (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-17743) Add InterfaceAudience and InterfaceStability annotations for Thrift generated APIs
Date Fri, 13 Oct 2017 20:12:02 GMT

    [ https://issues.apache.org/jira/browse/HIVE-17743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16204115#comment-16204115
] 

Sahil Takiar commented on HIVE-17743:
-------------------------------------

Unfortunately, the patch is a bit too big to fit in an RB, but here is a summary of the changes:
* Modified the {{standalone-metastore/pom.xml}} and {{service-rpc/pom.xml}} files to use the
{{maven-replacer-plugin}} to add {{InterfaceAudience.Public}} and {{InterfaceStability.Stable}}
annotations in front of the class declaration of each public Thrift generated class
* I had to move the annotations themselves into a separate maven module called {{classification}}
because {{service-rpc}} doesn't have a dependency on {{hive-common}}

> Add InterfaceAudience and InterfaceStability annotations for Thrift generated APIs
> ----------------------------------------------------------------------------------
>
>                 Key: HIVE-17743
>                 URL: https://issues.apache.org/jira/browse/HIVE-17743
>             Project: Hive
>          Issue Type: Sub-task
>          Components: Thrift API
>            Reporter: Sahil Takiar
>            Assignee: Sahil Takiar
>         Attachments: HIVE-17743.1.patch, HIVE-17743.2.patch
>
>
> The Thrift generated files don't have {{InterfaceAudience}} or {{InterfaceStability}}
annotations on them, mainly because all the files are auto-generated.
> We should add some code that auto-tags all the Java Thrift generated files with these
annotations. This way even when they are re-generated, they still contain the annotations.
> We should be able to do this using the {{com.google.code.maven-replacer-plugin}} similar
to what we do in {{standalone-metastore/pom.xml}}.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message